Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 404 response when changing a non-existing role #522

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Return 404 response when changing a non-existing role #522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...m2.common/src/main/java/org/wso2/carbon/identity/scim2/common/impl/SCIMRoleManagerV2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,7 +714,7 @@ private void doUpdateRoleName(RoleV2 oldRole, RoleV2 newRole)
}
}

private String getCurrentRoleName(String roleId, String tenantDomain) throws CharonException, BadRequestException {
private String getCurrentRoleName(String roleId, String tenantDomain) throws CharonException, NotFoundException {

String currentRoleName;
try {
Expand All @@ -724,7 +724,7 @@ private String getCurrentRoleName(String roleId, String tenantDomain) throws Cha
}
} catch (IdentityRoleManagementException e) {
if ((ROLE_NOT_FOUND.getCode()).equals(e.getErrorCode())) {
throw new BadRequestException(e.getMessage());
throw new NotFoundException(e.getMessage());
}
throw new CharonException(String.format("Error occurred while getting the role name by " +
"the role id: %s", roleId), e);
Expand Down
Loading