Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 404 response when changing a non-existing role #522

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Return 404 response when changing a non-existing role #522

merged 1 commit into from
Jan 22, 2024

Conversation

hwupathum
Copy link
Contributor

Fixes wso2/product-is#19092

The following response will be given now for the PATCH /scim2/v2/Roles/invalidRole request

{
    "schemas": [
        "urn:ietf:params:scim:api:messages:2.0:Error"
    ],
    "detail": "A role doesn't exist with id: invalidRole in the tenantDomain: carbon.super",
    "status": "404"
}

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7613635499

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7613635499
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Jan 22, 2024
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7613635499

@hwupathum hwupathum merged commit b01e383 into wso2-extensions:master Jan 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnuradhaSK AnuradhaSK AnuradhaSK approved these changes

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@dewniMW dewniMW Awaiting requested review from dewniMW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect response when changing a non-existing role
3 participants
@hwupathum @jenkins-is-staging @AnuradhaSK