Fix: SCIM error handling for group display name (fixes #20344) #557
Conversation
|
Bimsara Bodaragama seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
…values (fixes #20334)
| // Error message and SCIM type | ||
| String errorMessage = "Updating groups of the role by display name is not supported. " | ||
| + "Update using group id instead."; | ||
| String scimType = "invalidSyntax"; // From RFC 7644 Table 9 |
There was a problem hiding this comment.
Without hardcoding here you can directly use ResponseCodeConstants.INVALID_SYNTAX constant in charon
scimType variable is also redundant then
There was a problem hiding this comment.
Addressed in b974ba9
| @@ -1125,7 +1125,13 @@ private void doUpdateGroups(String roleId, Set<String> newGroupIDList, Set<Strin | |||
| new ArrayList<>(deleteGroupIDList), tenantDomain); | |||
| } catch (IdentityRoleManagementException e) { | |||
| if (RoleConstants.Error.INVALID_REQUEST.getCode().equals(e.getErrorCode())) { | |||
| throw new BadRequestException(e.getMessage()); | |||
| // Error message and SCIM type | |||
| String errorMessage = "Updating groups of the role by display name is not supported. " | |||
There was a problem hiding this comment.
Is this the correct place to handle the mentioned error?
Issue should be directly taking display eq ... something as group id
We have to throw the error from that place
There was a problem hiding this comment.
Addressed in b974ba9
…Remove-Add-Replace operations (fixes #20334)
|
|
||
| String value = groupObject.get(SCIMConstants.CommonSchemaConstants.VALUE); | ||
|
|
||
| if (value == null) { |
There was a problem hiding this comment.
Shall we use the StringUtils?
…ty check (fixes #20334)
Purpose
Fix SCIM error handling to provide appropriate messages when a group display name is used instead of a group ID.
Goals
To ensure compliance with RFC 7644 and provide clear, actionable error messages to users when an invalid request is made with a group display name.
Approach
scimTypeset toinvalidSyntaxfor requests using a group display name instead of a group ID.detailfield.Issue
Resolves #20334