Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: SCIM error handling for group display name (fixes #20344) #557

Closed
wants to merge 6 commits into from
Closed

Fix: SCIM error handling for group display name (fixes #20344) #557

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8388c51
Fix: SCIM error handling for group display name (fixes #20344)
Jun 28, 2024
9f11dc4
Fix SCIM error handling with generalized message for invalid request …
Jun 28, 2024
d18b5ae
Generalize SCIM error message for invalid request values (fixes #20334)
Jun 28, 2024
b974ba9
Fix SCIM error message for invalid request values in V1 and V2 Roles …
Jul 1, 2024
33c09b9
Refactor SCIM error handling to directly use error message string (fi…
Jul 1, 2024
0961878
Refactor prepareInitialGroupLists to use StringUtils for null and emp…
BimsaraBodaragama Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...m2.common/src/main/java/org/wso2/carbon/identity/scim2/common/impl/SCIMRoleManagerV2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1125,7 +1125,13 @@ private void doUpdateGroups(String roleId, Set<String> newGroupIDList, Set<Strin
new ArrayList<>(deleteGroupIDList), tenantDomain);
} catch (IdentityRoleManagementException e) {
if (RoleConstants.Error.INVALID_REQUEST.getCode().equals(e.getErrorCode())) {
throw new BadRequestException(e.getMessage());
// Error message and SCIM type
String errorMessage = "Updating groups of the role by display name is not supported. "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the correct place to handle the mentioned error?
Issue should be directly taking display eq ... something as group id
We have to throw the error from that place

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in b974ba9

+ "Update using group id instead.";
String scimType = "invalidSyntax"; // From RFC 7644 Table 9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without hardcoding here you can directly use ResponseCodeConstants.INVALID_SYNTAX constant in charon

scimType variable is also redundant then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in b974ba9


// Throw BadRequestException with custom message and scimType
throw new BadRequestException(errorMessage, scimType);
}
throw new CharonException(
String.format("Error occurred while updating groups in the role with ID: %s", roleId), e);
Expand Down
Loading