Re-add runtime exception when validating for actions to be handled at the upper layer . #5827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ution/src/main/java/org/wso2/carbon/identity/action/execution/ActionExecutorServiceImpl.java
Show resolved
Hide resolved
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10179610529
ashanthamara
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
This adds back the runtime exception removed as per a review comment due to following.
This method is intended to handle the validation and to break the flow based on the validation given the different types of validations it needs to cater for.
Related to wso2/product-is#20739 and resolves a bug that let the actions to be invoked even when there are no actions available as the flow doesn't break properly.
When should this PR be merged
Soon