Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add runtime exception when validating for actions to be handled at the upper layer . #5827

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Re-add runtime exception when validating for actions to be handled at the upper layer . #5827

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f3c26a
re-add runtime exception for validation.
malithie Jul 31, 2024
911b476
Merge branch 'master' into actions-core
malithie Jul 31, 2024
477fce2
Logged runtime excpetions as a debug due to less sensitivity.
malithie Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ...on/src/main/java/org/wso2/carbon/identity/action/execution/ActionExecutorServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public ActionExecutionStatus execute(ActionType actionType, Map<String, Object>
.orElse(new ActionExecutionStatus(ActionExecutionStatus.Status.FAILED, eventContext));
} catch (ActionExecutionRuntimeException e) {
// todo: add to diagnostics
LOG.error("Skip executing actions for action type: " + actionType.name() + ". Error: " + e.getMessage(), e);
LOG.debug("Skip executing actions for action type: " + actionType.name(), e);
malithie marked this conversation as resolved.
Show resolved Hide resolved
return new ActionExecutionStatus(ActionExecutionStatus.Status.FAILED, eventContext);

}
Expand All @@ -112,10 +112,7 @@ private List<Action> getActionsByActionType(ActionType actionType, String tenant
private void validateActions(List<Action> actions, ActionType actionType) throws ActionExecutionException {

if (CollectionUtils.isEmpty(actions)) {
if (LOG.isDebugEnabled()) {
LOG.debug("No actions found for action type: " + actionType);
}
return;
throw new ActionExecutionRuntimeException("No actions found for action type: " + actionType);
}

if (actions.size() > 1) {
Expand Down
Loading