Application warning banner #6813
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Design comments
|
Achintha444
reviewed
Aug 26, 2024
Achintha444
reviewed
Aug 26, 2024
Achintha444
reviewed
Aug 26, 2024
| */ | ||
| const resolveAlertBanner = (): ReactElement => { | ||
|
|
||
| const classes: any = classNames( { "application-outdated-alert-expanded-view": viewBannerDetails } ); |
There was a problem hiding this comment.
refrain from using any.
There was a problem hiding this comment.
I think we can replace any with string here.
Achintha444
reviewed
Aug 26, 2024
Achintha444
reviewed
Aug 26, 2024
Achintha444
reviewed
Aug 26, 2024
| @@ -33,21 +37,27 @@ import { ExtensionTemplateListInterface } from "@wso2is/admin.template-core.v1/m | |||
| import { isFeatureEnabled } from "@wso2is/core/helpers"; | |||
| import { AlertLevels, IdentifiableComponentInterface } from "@wso2is/core/models"; | |||
| import { addAlert } from "@wso2is/core/store"; | |||
| import { Field, Forms } from "@wso2is/forms"; | |||
There was a problem hiding this comment.
do not use Forms use FinalForm instead.
view this PR for more details, "https://github.com/wso2/identity-apps/pull/6722/files#diff-d94522cb3bcc2277d7af7c0f1c38e4e8d1d7659edb195199b995d045be70b235"
Achintha444
reviewed
Aug 26, 2024
Achintha444
reviewed
Aug 26, 2024
Achintha444
reviewed
Aug 26, 2024
| /** | ||
| * Handles banner content update action which prepares data. | ||
| */ | ||
| const handleBannerCheckBoxUpdate = (formDataValues: any) => { |
There was a problem hiding this comment.
refrain from using any
Achintha444
reviewed
Aug 26, 2024
| const handleBannerCheckBoxUpdate = (formDataValues: any) => { | ||
|
|
||
| // Todo: check if we need to send all configs. Though the method is PUT, it works as a PATCH. | ||
| let values: any = { ...applicationInboundConfig }; |
There was a problem hiding this comment.
refrain from using any
Achintha444
reviewed
Aug 26, 2024
|
fix eslint issues. |
mpmadhavig
force-pushed
the
application-warning-banner
branch
from
d71fefd
to
33b932c
Compare
10 tasks
mpmadhavig
force-pushed
the
application-warning-banner
branch
from
2a922b2
to
025df58
Compare
Updated UI
|
mpmadhavig
force-pushed
the
application-warning-banner
branch
from
088ed45
to
007118f
Compare
Removed with 007118f
Removed with 007118f
Fixed with 025df58 
|
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
Design comments - Cont.
cc: @savindi7 @jeradrutnam WDYT ? |
Achintha444
reviewed
Aug 28, 2024
Comment on lines
+627
to
+628
| const resolveBannerViewDetails = (): ReactElement => { | ||
| return ( |
There was a problem hiding this comment.
Suggested change
| const resolveBannerViewDetails = (): ReactElement => { | |
| return ( | |
| const resolveBannerViewDetails = (): ReactElement => { |
Achintha444
reviewed
Aug 28, 2024
Comment on lines
+769
to
+770
| const confirmationModal = () => { | ||
| return ( |
There was a problem hiding this comment.
Suggested change
| const confirmationModal = () => { | |
| return ( | |
| const confirmationModal = (): ReactElement => { |
Achintha444
reviewed
Aug 28, 2024
| const handleBannerCheckBoxUpdateConfirmation = async (): Promise<void> => { | ||
| setBannerUpdateLoading(true); | ||
|
|
||
| return updateAuthProtocolConfig<OIDCDataInterface>(application?.id, formData, SupportedAuthProtocolTypes.OIDC) |
There was a problem hiding this comment.
why returning this function and the return type set as void ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR will add a banner to the Application edit to maintain the below configs.
The initial UI design is as follows.
Screen.Recording.2024-08-26.at.10.36.10.mov
Related Issues
Related PRs
Checklist
Security checks