Remove dependency on originator node for blockchain envelopes #224
Conversation
| @@ -53,7 +52,6 @@ message UnsignedOriginatorEnvelope { | |||
| // An alternative to a signature for blockchain payloads | |||
| message BlockchainProof { | |||
| uint64 block_number = 1; | |||
| uint32 publisher_node_id = 2; | |||
There was a problem hiding this comment.
We could also include the transaction hash, since this proof gets generated when the message is read off the chain. That would make it easier to verify
There was a problem hiding this comment.
Do we expect recipients to verify both the block_number and transaction_hash? Or would the transaction_hash alone be sufficient to find the proof? Just trying to avoid redundant fields that need to be kept consistent where possible
There was a problem hiding this comment.
(Also, you can merge first, I'll apply this on top of your change)
There was a problem hiding this comment.
Think the hash could replace the block number, since you can get the block number with the hash
|
🎉 This PR is included in version 3.72.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
We allow anyone to publish to the blockchain directly, so there is no need to specify the
publisher_node_id. Theoriginator_nsfield on theUnsignedOriginatorEnvelopewill be derived from the block time.