Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on originator node for blockchain envelopes #224

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Remove dependency on originator node for blockchain envelopes #224

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fd7a4f
feat: remove dependency on originator node for blockchain envelopes
richardhuaaa Oct 18, 2024
9338139
Merge remote-tracking branch 'origin/main' into rich/remove-originato…
richardhuaaa Oct 18, 2024
b18bc3f
refactor: replace block number with transaction hash
richardhuaaa Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions proto/xmtpv4/envelopes/envelopes.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ message PayerEnvelope {
xmtp.identity.associations.RecoverableEcdsaSignature payer_signature = 2;
}

// For blockchain envelopes, the originator_sid is set by the smart contract,
// but the originator_ns is set by the publishing node
// For blockchain envelopes, these fields are set by the smart contract
message UnsignedOriginatorEnvelope {
uint32 originator_node_id = 1;
uint64 originator_sequence_id = 2;
Expand All @@ -50,8 +49,7 @@ message UnsignedOriginatorEnvelope {

// An alternative to a signature for blockchain payloads
message BlockchainProof {
uint64 block_number = 1;
uint32 publisher_node_id = 2;
bytes transaction_hash = 1;
}

// Signed originator envelope
Expand Down
Loading