Fix: remove_sub_pool should kill subprocess gracefully #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix bug of xinference: Only the main process got kill, but subprocess leaves behind before terminate-model: root 179070 1942 1.3 60529056 7144300 ? Rl 04:22 9:23 \_ Model: qwen2-instruct:72-0-1722111769.2038095 root 179297 2395 1.3 59784688 6867800 ? Rl 04:22 9:34 | \_ Model: qwen2-instruct:72-0-1722111769.2038095 root 179300 2373 1.3 59784740 6881352 ? Rl 04:22 9:29 | \_ Model: qwen2-instruct:72-0-1722111769.2038095 root 179301 2362 1.2 59747064 6858788 ? Rl 04:22 9:26 | \_ Model: qwen2-instruct:72-0-1722111769.2038095 after terminate-model: root 179297 2395 1.3 59784688 6867800 ? Rl 04:22 9:34 \_ Model: qwen2-instruct:72-0-1722111769.2038095 root 179300 2373 1.3 59784740 6881352 ? Rl 04:22 9:29 \_ Model: qwen2-instruct:72-0-1722111769.2038095 root 179301 2362 1.2 59747064 6858788 ? Rl 04:22 9:26 \_ Model: qwen2-instruct:72-0-1722111769.2038095
frostyplanet
force-pushed
the
fix_remove_sub_pool
branch
from
92a5c3c
to
301bd8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix bug of xinference:
Only the main process got kill, but subprocess leaves behind
before terminate-model:
root 179070 1942 1.3 60529056 7144300 ? Rl 04:22 9:23 _ Model: qwen2-instruct:72-0-1722111769.2038095
root 179297 2395 1.3 59784688 6867800 ? Rl 04:22 9:34 | _ Model: qwen2-instruct:72-0-1722111769.2038095
root 179300 2373 1.3 59784740 6881352 ? Rl 04:22 9:29 | _ Model: qwen2-instruct:72-0-1722111769.2038095
root 179301 2362 1.2 59747064 6858788 ? Rl 04:22 9:26 | _ Model: qwen2-instruct:72-0-1722111769.2038095
after terminate-model:
root 179297 2395 1.3 59784688 6867800 ? Rl 04:22 9:34 _ Model: qwen2-instruct:72-0-1722111769.2038095
root 179300 2373 1.3 59784740 6881352 ? Rl 04:22 9:29 _ Model: qwen2-instruct:72-0-1722111769.2038095
root 179301 2362 1.2 59747064 6858788 ? Rl 04:22 9:26 _ Model: qwen2-instruct:72-0-1722111769.2038095
What do these changes do?
Related issue number
Fixes #xxxx
Check code requirements