Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove_sub_pool should kill subprocess gracefully #97

Merged
merged 1 commit into from
Jul 30, 2024

Commits on Jul 29, 2024

  1. Fix: remove_sub_pool should kill subprocess gracefully

    This fix bug of xinference:
    
    Only the main process got kill, but subprocess leaves behind
    
    before terminate-model:
    root      179070 1942  1.3 60529056 7144300 ?    Rl   04:22   9:23              \_ Model: qwen2-instruct:72-0-1722111769.2038095
    root      179297 2395  1.3 59784688 6867800 ?    Rl   04:22   9:34              |   \_ Model: qwen2-instruct:72-0-1722111769.2038095
    root      179300 2373  1.3 59784740 6881352 ?    Rl   04:22   9:29              |   \_ Model: qwen2-instruct:72-0-1722111769.2038095
    root      179301 2362  1.2 59747064 6858788 ?    Rl   04:22   9:26              |   \_ Model: qwen2-instruct:72-0-1722111769.2038095
    
    after terminate-model:
    root      179297 2395  1.3 59784688 6867800 ?    Rl   04:22   9:34              \_ Model: qwen2-instruct:72-0-1722111769.2038095
    root      179300 2373  1.3 59784740 6881352 ?    Rl   04:22   9:29              \_ Model: qwen2-instruct:72-0-1722111769.2038095
    root      179301 2362  1.2 59747064 6858788 ?    Rl   04:22   9:26              \_ Model: qwen2-instruct:72-0-1722111769.2038095
    frostyplanet committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    301bd8c View commit details
    Browse the repository at this point in the history