Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variants: Add rpi_pico #115

Merged
merged 2 commits into from
Sep 1, 2024
Merged

variants: Add rpi_pico #115

merged 2 commits into from
Sep 1, 2024

Conversation

soburi
Copy link
Member

@soburi soburi commented Aug 5, 2024

Add support for RaspberryPi Pico

@soburi soburi marked this pull request as draft August 6, 2024 06:39
@soburi soburi marked this pull request as ready for review August 12, 2024 23:07
Copy link
Collaborator

@DhruvaG2000 DhruvaG2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no way of testing this ATM, but code-wise it looks good.

@DhruvaG2000
Copy link
Collaborator

Can you please rebase and force push?

Add support for RaspberryPi Pico

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
zephyr,acquisition-time = <ADC_ACQ_TIME_DEFAULT>;
zephyr,resolution = <12>;
};
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, do you want to have anything in CI for checking if this platform builds fine for atleast 1 sample?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If yes, please feel free to submit it with this PR itself

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, do you want to have anything in CI for checking if this platform builds fine for atleast 1 sample?

I'm not familiar with github actions, but you might be able to combine a sample and a board in this way.

https://docs.github.com/en/enterprise-cloud@latest/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow#about-matrix-strategies

@soburi soburi merged commit 0af5724 into zephyrproject-rtos:next Sep 1, 2024
2 of 3 checks passed
@soburi soburi deleted the rpi_pico branch September 1, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants