-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
variants: Add rpi_pico #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no way of testing this ATM, but code-wise it looks good.
Can you please rebase and force push? |
Add support for RaspberryPi Pico Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
zephyr,acquisition-time = <ADC_ACQ_TIME_DEFAULT>; | ||
zephyr,resolution = <12>; | ||
}; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, do you want to have anything in CI for checking if this platform builds fine for atleast 1 sample?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If yes, please feel free to submit it with this PR itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, do you want to have anything in CI for checking if this platform builds fine for atleast 1 sample?
I'm not familiar with github actions, but you might be able to combine a sample and a board in this way.
Add support for RaspberryPi Pico