Allows QIO and QOUT flash modes #337
Conversation
|
@wmrsouza - thanks for taking a look at this issue. I had tried enabling the flash wrap back in June and ran into a problem with the flash chip ID functionality. Has that been fixed, now? See zephyrproject-rtos/zephyr#73677 (comment) for details on the issue I ran into. |
|
Unfortunately, it's not fixed yet. I'm debugging the issue and will open this PR for review once it's working. |
wmrsouza
force-pushed
the
bugfix/QIO_mode
branch
from
0e9217d
to
65ebea6
Compare
wmrsouza
force-pushed
the
bugfix/QIO_mode
branch
2 times, most recently
from
f4d2503
to
c6a4556
Compare
wmrsouza
force-pushed
the
bugfix/QIO_mode
branch
from
c6a4556
to
2b468d8
Compare
wmrsouza
changed the title
wmrsouza
requested review from
raffarost,
marekmatej,
LucasTambor and
sylvioalves
zephyr/esp32s3/CMakeLists.txt
Outdated
| @@ -5,6 +5,8 @@ if(CONFIG_SOC_SERIES_ESP32S3) | |||
| zephyr_compile_options(-fstrict-volatile-bitfields) | |||
| zephyr_compile_definitions_ifndef(CONFIG_MCUBOOT CONFIG_APP_BUILD_USE_FLASH_SECTIONS) | |||
| zephyr_compile_definitions_ifdef(CONFIG_MCUBOOT BOOTLOADER_BUILD) | |||
| zephyr_compile_definitions_ifdef(CONFIG_ESP_SIMPLE_BOOT AND CONFIG_ESPTOOLPY_FLASHMODE_QIO BOOTLOADER_BUILD) | |||
There was a problem hiding this comment.
I this case why not just leaving BOOTLOADER_BUILD enabled?
zephyr_compile_definitions_ifdef(CONFIG_ESP_SIMPLE_BOOT BOOTLOADER_BUILD)
|
@wmrsouza, move |
| @@ -145,7 +147,7 @@ if(CONFIG_SOC_SERIES_ESP32S3) | |||
| ../../components/spi_flash/spi_flash_hpm_enable.c | |||
| ../../components/spi_flash/spi_flash_os_func_noos.c | |||
| ../../components/spi_flash/spi_flash_os_func_app.c | |||
| # todo: ../../components/spi_flash/spi_flash_wrap.c | |||
| ../../components/spi_flash/spi_flash_wrap.c | |||
There was a problem hiding this comment.
Looks like this is the only change in this commit which I had tried back in June (see zephyrproject-rtos/zephyr#73677 (comment)). If this works now, then it seems that the root cause was fixed in some other changes that have already been merged.
There was a problem hiding this comment.
In fact, this change will only fix the issue together with this other PR being merged on the Zephyr side:
zephyrproject-rtos/zephyr#79286
wmrsouza
force-pushed
the
bugfix/QIO_mode
branch
4 times, most recently
from
a4f5cfe
to
a3ed4dc
Compare
wmrsouza
changed the title
wmrsouza
force-pushed
the
bugfix/QIO_mode
branch
from
a3ed4dc
to
06979f1
Compare
Changes to allow QIO and QOUT flash mode to work in: - esp32s2 - esp32s3 - esp32c2 - esp32c3 - esp32c6 Signed-off-by: Marcio Ribeiro <marcio.ribeiro@espressif.com>
wmrsouza
force-pushed
the
bugfix/QIO_mode
branch
from
06979f1
to
7fee019
Compare
wmrsouza
changed the title
Allows QIO and QOUT flash modes to work in: