bugfix: esp32: allows QIO and QOUT flash modes #79286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmrsouza
force-pushed
the
bugfix/QIO_mode
branch
from
a756e4f
to
58f37e6
Compare
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_espressif
DNM
wmrsouza
force-pushed
the
bugfix/QIO_mode
branch
from
58f37e6
to
43151dc
Compare
wmrsouza
changed the title
zephyrbot
requested review from
LucasTambor,
marekmatej,
raffarost,
sylvioalves and
uLipe
wmrsouza
force-pushed
the
bugfix/QIO_mode
branch
from
43151dc
to
d8822a6
Compare
sylvioalves
reviewed
Oct 8, 2024
soc/espressif/esp32s3/default.ld
Outdated
| @@ -436,6 +436,10 @@ SECTIONS | |||
| *libzephyr.a:bootloader_console.*(.literal .text .literal.* .text.*) | |||
| *libzephyr.a:bootloader_panic.*(.literal .text .literal.* .text.*) | |||
|
|
|||
| #if defined(CONFIG_ESPTOOLPY_FLASHMODE_QIO) || defined(CONFIG_ESPTOOLPY_FLASHMODE_QOUT) | |||
There was a problem hiding this comment.
I think you can dismiss this conditions in both cases.
wmrsouza
force-pushed
the
bugfix/QIO_mode
branch
3 times, most recently
from
adb1ae9
to
e8a07aa
Compare
wmrsouza
changed the title
wmrsouza
force-pushed
the
bugfix/QIO_mode
branch
2 times, most recently
from
c7dfa83
to
528bba1
Compare
raffarost
previously approved these changes
Oct 10, 2024
wmrsouza
force-pushed
the
bugfix/QIO_mode
branch
2 times, most recently
from
156e931
to
6894fc3
Compare
wmrsouza
force-pushed
the
bugfix/QIO_mode
branch
from
6894fc3
to
f8d89c7
Compare
wmrsouza
added
DNM
wmrsouza
force-pushed
the
bugfix/QIO_mode
branch
from
f8d89c7
to
31be034
Compare
LucasTambor
approved these changes
Oct 11, 2024
wmrsouza
force-pushed
the
bugfix/QIO_mode
branch
from
31be034
to
27922b0
Compare
Update hal to cover latest features and fixes. Signed-off-by: Marcio Ribeiro <marcio.ribeiro@espressif.com>
Allows QIO and QOUT flash mode to work on: - esp32s2 - esp32s3 - esp32c2 - esp32c3 - esp32c6 Fixes zephyrproject-rtos#73677 Signed-off-by: Marcio Ribeiro <marcio.ribeiro@espressif.com>
wmrsouza
force-pushed
the
bugfix/QIO_mode
branch
from
27922b0
to
21ef7c9
Compare
uLipe
approved these changes
Oct 14, 2024
sylvioalves
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows QIO and QOUT flash modes to work in:
Fixes #73677