Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dts: nxp: nxp_imx: rt500: update pinctrl files #439

Conversation

lucien-nxp
Copy link
Contributor

Re-generate pinctrl files for RT500 according to data patch

@lucien-nxp
Copy link
Contributor Author

Pinout need to be double check. So this PR need to wait the result of confirmation.

@dleach02
Copy link
Member

@lucien-nxp We need a Zephyr side PR to ensure CI is okay

@lucien-nxp
Copy link
Contributor Author

Added pinout have been confirmed. Please help review the PR. Thank you.

@danieldegrasse
Copy link
Collaborator

@lucien-nxp We need a Zephyr side PR to ensure CI is okay

What @dleach02 means by this is that we need a PR on the Zephyr side pulling this PR in (referencing it within the west.yml as pull/439/head, so we can verify that everything still builds with CI before merging this change)

@danieldegrasse
Copy link
Collaborator

Actually looking at this more, this is strictly additions- @dleach02 do you think we really need a full CI run for this change?

@lucien-nxp
Copy link
Contributor Author

@lucien-nxp We need a Zephyr side PR to ensure CI is okay

What @dleach02 means by this is that we need a PR on the Zephyr side pulling this PR in (referencing it within the west.yml as pull/439/head, so we can verify that everything still builds with CI before merging this change)

I will wait for David's respond about CI test. If needed, I will create a pr in zephyr side.

@henrikbrixandersen
Copy link
Member

I will wait for David's respond about CI test. If needed, I will create a pr in zephyr side.

This is always needed. It's a Zephyr project policy, not an NXP policy.

@danieldegrasse
Copy link
Collaborator

This is always needed. It's a Zephyr project policy, not an NXP policy.

Yeah, the documented process does request a Zephyr PR always be created. @lucien-nxp can you please make one?

Re-generate pinctrl files for RT500 according to data patch

Signed-off-by: Lucien Zhao <lucien.zhao@nxp.com>
@lucien-nxp
Copy link
Contributor Author

pinctrl file will be changed to a new model on RT 3 platforms, so there is no need to update on this PR.

@lucien-nxp lucien-nxp closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants