mt8195_adsp support #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
Headers for the MT8195 Audio DSP. Specifically these were extracted from a just-configured Cadence RI-2021.6 toolchain for the core "hifi4_8195_PROD". Signed-off-by: Andy Ross <andyross@google.com>
The "addi.a" instruction referenced in this file doesn't build with non-Cadence assemblers. By name, it would seem to be a "add immediate single precision floating point", but the way it's used is clearly as an integer counter in a regular GPR. Use an addi, which seems to be the intent, to make this build. In practice this code won't ever be executed by Zephyr apps anyway. Signed-off-by: Andy Ross <andyross@google.com>
|
Rebase and take Daniel's suggestion about the weird instruction. Which... I mean I guess it's probably the same as an addi, but it's absolutely not documented anywhere... But for sure building one possibly-broken code path in a HAL file that will never be used is cleaner than disabling the whole file. |
dcpleung
approved these changes
Aug 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Headers for the mt8195_adsp device. See zephyrproject-rtos/zephyr#61197 and zephyrproject-rtos/sdk-ng#694
Note the disabled file (albeit a really obscure one I promise no one will need) in the HAL build. Seems like current Cadence headers have skewed far enough away from our HAL code that some things are breaking.