Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nxp_rt500_adsp support #23

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Conversation

dbaluta
Copy link
Contributor

@dbaluta dbaluta commented Sep 18, 2023

Headers fo nxp_rt500_adsp.

See: zephyrproject-rtos/sdk-ng#696 and zephyrproject-rtos/zephyr#61356.

Similar with #21 we fix an assembler error in patch 2.

Headers for RT500 Cadence Fusion F1 DSP. These were extracted from
Cadence RI2021_8 toolchain with core nxp_rt500_RI2021_8_newlib.

Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Similar with
commit 8dd7640 ("soc/mt8195_adsp: Fix assembly for older toolchain").

The "addi.a" instruction referenced in this file doesn't build with
non-Cadence assemblers.  By name, it would seem to be a "add immediate
single precision floating point", but the way it's used is clearly
as an integer counter in a regular GPR.  Use an addi, which seems to
be the intent, to make this build.  In practice this code won't ever
be executed by Zephyr apps anyway.

Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
@dbaluta
Copy link
Contributor Author

dbaluta commented Sep 18, 2023

@dleach02 @mmahadevan108 @dcpleung @LaurentiuM1234 please help review this.

Copy link

@LaurentiuM1234 LaurentiuM1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! CC'ing @andyross @nashif for approvals since mine doesn't count.

@mmahadevan108 mmahadevan108 merged commit e6da34f into zephyrproject-rtos:master Sep 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants