libc: Default to picolibc where supported #57340

keith-packard · 2023-04-27T13:33:38Z

This switches the default C library to picolibc for all targets which support it.

carlescufi · 2023-04-27T13:40:14Z

@keith-packard labeling this as TSC since this requires a bit more discussion.

zephyrbot · 2023-04-27T17:07:48Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff
mcuboot	zephyrproject-rtos/mcuboot@`1558e7a` (main)	zephyrproject-rtos/mcuboot@`2878eb4` (upstream-sync)	zephyrproject-rtos/mcuboot@1558e7ab..2878eb4e
picolibc	zephyrproject-rtos/picolibc@`93b5d5f` (main)	zephyrproject-rtos/picolibc@zephyr-source	zephyrproject-rtos/picolibc@93b5d5f2..zephyr-source
sof	zephyrproject-rtos/sof@`ffbf9c2` (zephyr)	zephyrproject-rtos/sof#28	zephyrproject-rtos/sof#28/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

marc-hb · 2023-05-01T17:16:24Z

One of the commit messages is:

modules/audio/sof: Pull fix for main return type

Upstream PR #28 switches return type of 'main' to 'int'.

Signed-off-by: Keith Packard keithp@keithp.com

Pull request 28 does not seem related. It's from 2017 :-)

EDIT: got it, you meant zephyrproject-rtos/sof/pull/28, not #28

Could you please share a link with more information about this change of the main prototype? It seems related to picolibc but so are many other changes so it does not narrow it down.

keith-packard · 2023-05-01T18:30:04Z

EDIT: got it, you meant zephyrproject-rtos/sof/pull/28, not #28

Sorry for the mis-leading link.

Could you please share a link with more information about this change of the main prototype? It seems related to picolibc but so are many other changes so it does not narrow it down.

Yeah, this is only vaguely related to picolibc itself -- as a complete C library, it's best to compile applications using picolibc without the -ffreestanding compiler flag as that improves code generation and error detection. But, with that option not present, clang makes mis-matching main type a fatal error. So, that means we needed to switch the return type to int. That series, #54628 was merged a while ago.

lib/libc/Kconfig

stephanosio · 2023-05-03T17:15:31Z

As per #49922 (comment), this needs more documentation and process-related work before it can be approved by the TSC.

I will look into that and create a new PR based on this with the necessary changes.

Can you please re-review?

nashif · 2023-09-04T14:57:55Z

lib/libc/Kconfig

 default NEWLIB_LIBC if REQUIRES_FULL_LIBC
- default PICOLIBC if REQUIRES_FULL_LIBC
 default MINIMAL_LIBC


dont we end up with both picolibc and minimal libc set as default? or does order here play a role?

Kconfig appears to pick the first which matches and which can be enabled -- the goal is to use picolibc where supported otherwise use minimal C library.

carlescufi · 2023-09-04T16:30:24Z

@keith-packard, now that we have a migration guide, would you mind adding a note there? I assume under "Required changes", given that users may see their applications break depending on what they are using?

keith-packard · 2023-09-04T18:32:52Z

@keith-packard, now that we have a migration guide, would you mind adding a note there? I assume under "Required changes", given that users may see their applications break depending on what they are using?

#62261 has some possible things to check. I'm not sure how these should be integrated into the rest of the migration notes though.

The tests `content_json` and `content_plain_test` depend on the float support of libc. After PR#zephyrproject-rtos#57340, Picolibc would be selected in these two tests and the `PICOLIBC_IO_FLOAT` won't be selected if the platform doesn't select `FPU`. This commit select `CONFIG_PICOLIBC` and `CONFIG_PICOLIBC_IO_FLOAT` for these two tests. Signed-off-by: Huifeng Zhang <Huifeng.Zhang@arm.com>

The tests `content_json` and `content_plain_test` depend on the float support of libc. After PR##57340, Picolibc would be selected in these two tests and the `PICOLIBC_IO_FLOAT` won't be selected if the platform doesn't select `FPU`. This commit select `CONFIG_PICOLIBC` and `CONFIG_PICOLIBC_IO_FLOAT` for these two tests. Signed-off-by: Huifeng Zhang <Huifeng.Zhang@arm.com>

The tests `content_json` and `content_plain_test` depend on the float support of libc. After PR#zephyrproject-rtos#57340, Picolibc would be selected in these two tests and the `PICOLIBC_IO_FLOAT` won't be selected if the platform doesn't select `FPU`. This commit select `CONFIG_PICOLIBC` and `CONFIG_PICOLIBC_IO_FLOAT` for these two tests. Signed-off-by: Huifeng Zhang <Huifeng.Zhang@arm.com>

The tests `content_json` and `content_plain_test` depend on the float support of libc. After PR#zephyrproject-rtos#57340, Picolibc would be selected in these two tests and the `PICOLIBC_IO_FLOAT` won't be selected if the platform doesn't select `FPU`. This commit select `CONFIG_PICOLIBC` and `CONFIG_PICOLIBC_IO_FLOAT` for these two tests. Signed-off-by: Huifeng Zhang <Huifeng.Zhang@arm.com> (cherry picked from commit 5a1a1fe) Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>

The tests `content_json` and `content_plain_test` depend on the float support of libc. After PR#zephyrproject-rtos#57340, Picolibc would be selected in these two tests and the `PICOLIBC_IO_FLOAT` won't be selected if the platform doesn't select `FPU`. This commit select `CONFIG_PICOLIBC` and `CONFIG_PICOLIBC_IO_FLOAT` for these two tests. Signed-off-by: Huifeng Zhang <Huifeng.Zhang@arm.com> (cherry picked from commit 5a1a1fe) Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no> (cherry picked from commit fb04730)

keith-packard added area: C Library C Standard Library DNM This PR should not be merged (Do Not Merge) area: picolibc Picolibc C Standard Library labels Apr 27, 2023

keith-packard requested a review from nashif as a code owner April 27, 2023 13:33

zephyrbot requested review from cfriedt and stephanosio April 27, 2023 13:34

zephyrbot assigned stephanosio Apr 27, 2023

carlescufi added the TSC Topics that need TSC discussion label Apr 27, 2023

stephanosio mentioned this pull request Apr 27, 2023

Make picolibc the default C library for Zephyr #49922

Closed

60 tasks

keith-packard force-pushed the picolibc-default branch from 3c3af68 to ab53da0 Compare April 27, 2023 15:55

keith-packard requested review from dcpleung and microbuilder as code owners April 27, 2023 15:55

zephyrbot added area: TF-M ARM Trusted Firmware-M (TF-M) area: Userspace Userspace labels Apr 27, 2023

zephyrbot requested review from ceolin and joerchan April 27, 2023 15:56

keith-packard force-pushed the picolibc-default branch from ab53da0 to 7f476df Compare April 27, 2023 17:06

zephyrbot added manifest manifest-sof manifest-mcuboot labels Apr 27, 2023

keith-packard force-pushed the picolibc-default branch from 7f476df to ee8fe4f Compare April 28, 2023 19:56

evgeniy-paltsev previously requested changes May 3, 2023

View reviewed changes

lib/libc/Kconfig Show resolved Hide resolved

keith-zephyr reviewed May 3, 2023

View reviewed changes

lib/libc/Kconfig Show resolved Hide resolved

keith-packard force-pushed the picolibc-default branch from ee8fe4f to 2c7f83e Compare May 3, 2023 16:17

keith-packard force-pushed the picolibc-default branch from 2c7f83e to 0e269c4 Compare May 8, 2023 16:44

fabiobaltieri approved these changes Aug 23, 2023

View reviewed changes

keith-packard mentioned this pull request Aug 24, 2023

Complete set of changes to enable picolibc by default #60124

Closed

joerchan removed request for joerchan, laurenmurphyx64, galak, dleach02, dcpleung, aasthagr and julius-barendt August 24, 2023 11:56

cfriedt approved these changes Aug 30, 2023

View reviewed changes

tejlmand approved these changes Sep 4, 2023

View reviewed changes

nashif removed the TSC Topics that need TSC discussion label Sep 4, 2023

nashif reviewed Sep 4, 2023

View reviewed changes

nashif approved these changes Sep 4, 2023

View reviewed changes

nashif merged commit 844c78c into zephyrproject-rtos:main Sep 4, 2023
38 of 39 checks passed

keith-packard deleted the picolibc-default branch September 4, 2023 20:13

fabiobaltieri mentioned this pull request Sep 4, 2023

doc/releases: Add picolibc migration notes #62261

Merged

glarsennordic mentioned this pull request Sep 6, 2023

tests: net: conn_mgr_monitor: increase stack size #62317

Merged

SgrrZhf mentioned this pull request Sep 8, 2023

RFC: arch: arm: Remove aarch32 directory and split Cortex-M and Cortex-A/r code #60031

Merged

SgrrZhf mentioned this pull request Sep 8, 2023

tests: net: lib: lwm2m: fix the missing float support #62431

Merged

feilongfl mentioned this pull request Sep 11, 2023

esp32: compile failed when enable sysbuild #62515

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libc: Default to picolibc where supported #57340

libc: Default to picolibc where supported #57340

keith-packard commented Apr 27, 2023 •

edited by stephanosio

Loading

carlescufi commented Apr 27, 2023

zephyrbot commented Apr 27, 2023 •

edited

Loading

marc-hb commented May 1, 2023 •

edited

Loading

keith-packard commented May 1, 2023

stephanosio commented May 3, 2023

nashif Sep 4, 2023

keith-packard Sep 4, 2023

carlescufi commented Sep 4, 2023

keith-packard commented Sep 4, 2023

libc: Default to picolibc where supported #57340

libc: Default to picolibc where supported #57340

Conversation

keith-packard commented Apr 27, 2023 • edited by stephanosio Loading

carlescufi commented Apr 27, 2023

zephyrbot commented Apr 27, 2023 • edited Loading

marc-hb commented May 1, 2023 • edited Loading

keith-packard commented May 1, 2023

stephanosio commented May 3, 2023

nashif Sep 4, 2023

Choose a reason for hiding this comment

keith-packard Sep 4, 2023

Choose a reason for hiding this comment

carlescufi commented Sep 4, 2023

keith-packard commented Sep 4, 2023

keith-packard commented Apr 27, 2023 •

edited by stephanosio

Loading

zephyrbot commented Apr 27, 2023 •

edited

Loading

marc-hb commented May 1, 2023 •

edited

Loading