native SDL drivers refactor so they can work with embedded libCs #60036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Display
area: Input
zephyrbot
requested review from
cfriedt,
fabiobaltieri,
gmarull,
henrikbrixandersen and
jfischer-no
|
Nit: I find the naming top/bottom a bit... odd IMO, commonly this is frontend/backend. But I guess it is a different context here. EDIT: why not simply use the |
Given all the confusion with the POSIX naming, I'm trying to avoid it as much as I can when referring to the "native" boards now. |
|
Thanks for the review @fabiobaltieri @pdgendt . I have done all changes @fabiobaltieri asked for. I hope you guys will be happy with it :) |
Split the SDL event handling code in a top and bottom to enable building it with embedded libCs. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
Split the SDL display driver in a top and bottom to enable using it with embedded libCs. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
pdgendt
reviewed
Jul 6, 2023
13 tasks
Split the SDL input driver in a top and bottom to enable using it with embedded libCs. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
Split the SDL GPIO emulator driver in a top and bottom to enable using it with embedded libCs. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
Now all SDL drivers can be used with the embedded libCs. Let's update the table. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
pdgendt
approved these changes
Jul 6, 2023
fabiobaltieri
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a plain refactor of the native SDL drivers into tops (Zephyr side) and bottoms (Linux side),
so the tops can be built with an embedded libC, while the bottoms remain built in the host context.
For native_posix there is effectively no change. For native_sim with this change, these drivers can be built now also when the user selects to build Zephyr with an embedded libC.
There is no functional changes, just code moved around.