shields: Add support for M5Stack mbus connector and core2 base shield #62315

MrMarteng · 2023-09-05T19:29:26Z

M5Stack base and core2 modules support an extension connector. This PR adds support for this connector.

It also includes support for the m5stack_core2 base shield, which features a MPU6886 6-axis motion tracker and a SPM1423
microphone.

MrMarteng · 2023-09-05T19:43:13Z

@kartben I started to prepare support for the m5stack connector. Maybe you find some time to have a look at it. I am happy for feedback.

MrMarteng · 2023-09-09T11:15:07Z

@kartben What's your preferred name for the extension header? Currently it's name m5stack_header. I also thought about mbus_header but mbus is also used by other brands.

MrMarteng · 2023-09-09T14:48:35Z

@kartben What's your preferred name for the extension header? Currently it's name m5stack_header. I also thought about mbus_header but mbus is also used by other brands.

I named the header m5stack,mbus-header. The shield that comes with m5stack is named m5stack_core2_base.

kartben · 2023-09-10T19:28:26Z

boards/shields/m5stack_core2_ext/doc/img/m5stack_core2_ext.jpg

~/Downloads > optimizt m5stack_core2_ext.jpg ℹ Optimizing 1 image (lossy)... ✔ m5stack_core2_ext.jpg 102.912 KB → 55.072 KB. Ratio: 46% ℹ Yay! You saved 47.84 KB (46%)

This commit adds basic support for the mbus connection port to m5stack_core2 board. Signed-off-by: Martin Kiepfer <m.kiepfer@teleschirm.org>

This commit adds support for mpu6886, which has compatible register layout. Signed-off-by: Martin Kiepfer <m.kiepfer@teleschirm.org>

kartben

I can't seem to be able to run the mpu6050 demo?

*** Booting Zephyr OS build v3.5.0-rc1-49-gc060ec527fa1 ***
Device mbus_mpu6886@68 is not ready

kartben · 2023-09-10T19:29:40Z

dts/bindings/gpio/m5stack,mbus-header.yaml

+description: |
+    GPIO pins exposed on M5Stack M-Bus headers.
+
+


extra blank line

boards/shields/m5stack_core2_ext/m5stack_core2_ext.overlay

kartben · 2023-10-03T11:03:28Z

boards/shields/m5stack_core2_ext/Kconfig.shield

+# Copyright (c) 2023 Martin Kiepfer <mrmarteng@teleschirm.org>
+# SPDX-License-Identifier: Apache-2.0
+
+config M5STACK_CORE2_EXT


Suggested change

config M5STACK_CORE2_EXT

config SHIELD_M5STACK_CORE2_EXT

kartben · 2023-10-03T11:14:41Z

boards/shields/m5stack_core2_ext/doc/index.rst

+For example:
+
+.. zephyr-app-commands::
+   :zephyr-app: samples/drivers/mpu6050


Suggested change

:zephyr-app: samples/drivers/mpu6050

:zephyr-app: samples/sensor/mpu6050

kartben · 2023-10-03T11:27:23Z

I can't seem to be able to run the mpu6050 demo?
*** Booting Zephyr OS build v3.5.0-rc1-49-gc060ec527fa1 ***
Device mbus_mpu6886@68 is not ready

I am suspecting issues with the AXP192, I see different behaviors /errors with cold boot vs. soft reset

kartben · 2023-10-03T11:51:33Z

Also, MPU6050 seemed pretty broken? See #63446

MrMarteng · 2023-10-03T12:03:43Z

I can't seem to be able to run the mpu6050 demo?
*** Booting Zephyr OS build v3.5.0-rc1-49-gc060ec527fa1 ***
Device mbus_mpu6886@68 is not ready
I am suspecting issues with the AXP192, I see different behaviors /errors with cold boot vs. soft reset

I cannot reproduce it yet

uart:~$ *** Booting Zephyr OS build zephyr-v3.4.0-4871-g9a969754e08d ***
Hello World! m5stack_core2
device list
devices:
- rtc@3ff48000 (READY)
- gpio@3ff44800 (READY)
- gpio@3ff44000 (READY)
- trng@3ff75144 (READY)
- uart@3ff40000 (READY)
- i2c@3ff53000 (READY)
- axp192@34 (READY)
- LDO3 (READY)
- LDO2 (READY)
- DCDC3 (READY)
- DCDC1 (READY)
- axp192_gpio (READY)
- ft5336@38 (READY)
- mbus_mpu6886@68 (READY)
uart:~$ sensor get mbus_mpu6886@68
channel idx=3 accel_xyz shift=4 value=25589900000ns, (0.148439, -0.272939, 10.606312)
channel idx=7 gyro_xyz shift=4 value=25589900000ns, (-0.120307, -0.263131, 0.298436)
uart:~$ sensor get mbus_mpu6886@68
channel idx=3 accel_xyz shift=4 value=27917600000ns, (0.047883, 8.683768, 3.193864)
channel idx=7 gyro_xyz shift=4 value=27917600000ns, (0.363853, -0.402757, 0.528260)
uart:~$ sensor get mbus_mpu6886@68
channel idx=3 accel_xyz shift=4 value=29257400000ns, (9.732428, -0.773328, 1.125273)
channel idx=7 gyro_xyz shift=4 value=29257400000ns, (-0.208640, -0.151350, 0.263796)

It doesn't make a difference on soft/hard reboot

Can you please check the priorities of CONFIG_REGULATOR_AXP192_INIT_PRIORITY, CONFIG_I2C_INIT_PRIORITY and CONFIG_SENSOR_INIT_PRIORITY. My default configuration is:

#define CONFIG_REGULATOR_AXP192_INIT_PRIORITY 76
#define CONFIG_GPIO_AXP192_INIT_PRIORITY 80
#define CONFIG_GPIO_HOGS_INIT_PRIORITY 81
#define CONFIG_I2C_INIT_PRIORITY 50
#define CONFIG_SENSOR_INIT_PRIORITY 90

Which project did you use for testing?

kartben · 2023-10-03T12:08:16Z

Which project did you use for testing?

It might have been my fault, sorry. I was testing against #63375, looks like it requires a slightly larger task than 2KB when running on the Core2. Works now :)

MrMarteng · 2023-10-03T12:12:26Z

Which project did you use for testing?

It might have been my fault, sorry. I was testing against #63375, looks like it requires a slightly larger task than 2KB when running on the Core2. Works now :)

Yes, I noticed this as well and increased the default stack size for m5stack in #62507 :-/

kartben

Neat! See my comments as well as earlier comments from today.

kartben · 2023-10-03T12:44:41Z

boards/shields/m5stack_core2_ext/doc/index.rst

+********
+
+M5Stack-Core2 comes with a base shield that is connected to the M5Stack
+extension connector. It features a MPU6886 6-axis motion tracker and a SPM1423


nit:

Suggested change

extension connector. It features a MPU6886 6-axis motion tracker and a SPM1423

extension connector. It features an MPU6886 6-axis motion tracker and a SPM1423

kartben · 2023-10-03T12:47:12Z

boards/shields/m5stack_core2_ext/doc/index.rst

+References
+**********
+
+.. target-notes::
+
+.. _datasheet:
+   https://docs.m5stack.com/en/core/core2


drop unless you actually have links/footnotes.

kartben · 2023-10-03T17:26:56Z

boards/xtensa/m5stack_core2/doc/index.rst

@@ -74,6 +74,7 @@ of the M5Stack Core2 board.
 +------------------+--------------------------------------------------------------------------+
 || 3-axis          || The `MPU-6886`_ is a 6-axis MotionTracking device that combines a       |
 || gyrosopce       || 3-axis gyroscope and a 3-axis accelerometer.                            |


well... now that you mention it ... :D

Suggested change

|| gyrosopce || 3-axis gyroscope and a 3-axis accelerometer. |

|| gyroscope || 3-axis gyroscope and a 3-axis accelerometer. |

Also, this is not even the correct description anyway -- should say something like "6 DOF IMU" or something?

I am not an expert on these sensors.I reworked the used terms in both documents (m5stack_core2 and m5stack_core2_ext).

M5Stack-Core2 comes with a base shield that is connected to the M5Stack extention connector. It features a MPU6886 6-axis motion tracker and a SPM1423 microphone. Signed-off-by: Martin Kiepfer <m.kiepfer@teleschirm.org>

MrMarteng · 2023-10-06T09:02:23Z

further comments?

carlescufi · 2023-10-23T08:40:02Z

@erwango ping

MrMarteng force-pushed the m5stack_connector branch from 61f4ecc to 3b08ea7 Compare September 5, 2023 19:41

MrMarteng force-pushed the m5stack_connector branch 4 times, most recently from da568d1 to ef607c4 Compare September 6, 2023 19:04

MrMarteng force-pushed the m5stack_connector branch from ef607c4 to 8ccbb71 Compare September 9, 2023 14:14

MrMarteng changed the title ~~shield: Support for M5Stack-Core2 connector and base shield~~ shields: Add support for M5Stack-Core2 connector and base shield Sep 9, 2023

MrMarteng force-pushed the m5stack_connector branch 2 times, most recently from 7326eb5 to a398134 Compare September 10, 2023 19:23

kartben reviewed Sep 10, 2023

View reviewed changes

MrMarteng force-pushed the m5stack_connector branch 4 times, most recently from 2d0ab8c to 944b4de Compare September 14, 2023 20:12

MrMarteng marked this pull request as ready for review September 15, 2023 05:22

MrMarteng requested review from nashif, galak, MaureenHelm, dcpleung and erwango as code owners September 15, 2023 05:22

zephyrbot added area: Shields Shields (add-on boards) area: Devicetree Binding PR modifies or adds a Device Tree binding area: Sensors Sensors labels Sep 15, 2023

zephyrbot requested review from avisconti, jfischer-no, teburd and tristan-google September 15, 2023 05:23

Martin Kiepfer added 2 commits October 3, 2023 11:34

boards: m5stack_core2: Add support for mbus connector

7334d59

This commit adds basic support for the mbus connection port to m5stack_core2 board. Signed-off-by: Martin Kiepfer <m.kiepfer@teleschirm.org>

sensors: mpu6050: Add support for variant mpu6886

f5ee484

This commit adds support for mpu6886, which has compatible register layout. Signed-off-by: Martin Kiepfer <m.kiepfer@teleschirm.org>

MrMarteng force-pushed the m5stack_connector branch from 9ccd8df to 9a96975 Compare October 3, 2023 09:35

MrMarteng requested a review from jfischer-no October 3, 2023 09:47

kartben reviewed Oct 3, 2023

View reviewed changes

kartben requested changes Oct 3, 2023

View reviewed changes

MrMarteng force-pushed the m5stack_connector branch from 9a96975 to 7d7b1da Compare October 3, 2023 14:11

MrMarteng requested a review from kartben October 3, 2023 14:46

kartben previously approved these changes Oct 3, 2023

View reviewed changes

MrMarteng dismissed kartben’s stale review via a9c33a1 October 3, 2023 17:06

MrMarteng force-pushed the m5stack_connector branch 2 times, most recently from a9c33a1 to 4954b5c Compare October 3, 2023 17:19

kartben reviewed Oct 3, 2023

View reviewed changes

MrMarteng force-pushed the m5stack_connector branch 2 times, most recently from 60af507 to 9f6ff57 Compare October 3, 2023 19:18

shields: Add support for M5Stack-Core2 base shield.

95da89a

M5Stack-Core2 comes with a base shield that is connected to the M5Stack extention connector. It features a MPU6886 6-axis motion tracker and a SPM1423 microphone. Signed-off-by: Martin Kiepfer <m.kiepfer@teleschirm.org>

MrMarteng force-pushed the m5stack_connector branch from 9f6ff57 to 95da89a Compare October 3, 2023 19:28

MrMarteng requested a review from kartben October 3, 2023 19:51

jfischer-no approved these changes Oct 4, 2023

View reviewed changes

kartben approved these changes Oct 6, 2023

View reviewed changes

fabiobaltieri added this to the v3.6.0 milestone Oct 6, 2023

MaureenHelm approved these changes Oct 23, 2023

View reviewed changes

carlescufi merged commit 82b1df2 into zephyrproject-rtos:main Oct 25, 2023
19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

shields: Add support for M5Stack mbus connector and core2 base shield #62315

shields: Add support for M5Stack mbus connector and core2 base shield #62315

MrMarteng commented Sep 5, 2023 •

edited

Loading

MrMarteng commented Sep 5, 2023

MrMarteng commented Sep 9, 2023

MrMarteng commented Sep 9, 2023

kartben Sep 10, 2023

kartben left a comment

kartben Sep 10, 2023

MrMarteng Oct 3, 2023

kartben Oct 3, 2023

MrMarteng Oct 3, 2023

kartben Oct 3, 2023

kartben commented Oct 3, 2023

kartben commented Oct 3, 2023

MrMarteng commented Oct 3, 2023

kartben commented Oct 3, 2023

MrMarteng commented Oct 3, 2023

kartben left a comment

kartben Oct 3, 2023

MrMarteng Oct 3, 2023

kartben Oct 3, 2023

MrMarteng Oct 3, 2023

kartben Oct 3, 2023

kartben Oct 3, 2023

MrMarteng Oct 3, 2023

MrMarteng commented Oct 6, 2023

carlescufi commented Oct 23, 2023

	:zephyr-app: samples/drivers/mpu6050
	:zephyr-app: samples/sensor/mpu6050

	extension connector. It features a MPU6886 6-axis motion tracker and a SPM1423
	extension connector. It features an MPU6886 6-axis motion tracker and a SPM1423

	\|\| gyrosopce \|\| 3-axis gyroscope and a 3-axis accelerometer. \|
	\|\| gyroscope \|\| 3-axis gyroscope and a 3-axis accelerometer. \|

shields: Add support for M5Stack mbus connector and core2 base shield #62315

shields: Add support for M5Stack mbus connector and core2 base shield #62315

Conversation

MrMarteng commented Sep 5, 2023 • edited Loading

MrMarteng commented Sep 5, 2023

MrMarteng commented Sep 9, 2023

MrMarteng commented Sep 9, 2023

Choose a reason for hiding this comment

kartben left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kartben commented Oct 3, 2023

kartben commented Oct 3, 2023

MrMarteng commented Oct 3, 2023

kartben commented Oct 3, 2023

MrMarteng commented Oct 3, 2023

kartben left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MrMarteng commented Oct 6, 2023

carlescufi commented Oct 23, 2023

MrMarteng commented Sep 5, 2023 •

edited

Loading