Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move footprint workflows to zephyr runners #63781

Merged

Conversation

nashif
Copy link
Member

@nashif nashif commented Oct 10, 2023

looks like our docker image is way too big for the GH runners, so move
to own runners until we have a better solution.

Signed-off-by: Anas Nashif anas.nashif@intel.com

kartben
kartben previously approved these changes Oct 10, 2023
@@ -22,7 +22,7 @@ concurrency:

jobs:
footprint-tracking:
runs-on: ubuntu-22.04
runs-on: zephyr-runner-linux-x64-4xlarge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, there exists zephyr-runner-linux-x64-xlarge, which has 4 vCPUs instead of 16 -- we likely do not need 16 vCPUs for these workflows.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last time I checked those were not working.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and it runs "only" twice a day anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one, yes. But we also have a PR related action.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. And is it really useful, btw? If I'm not mistaken it's not setting the diff as a "build output" (hence making it cumbersome to quickly go and look for the information in the job), and, more importantly, it's not really failing (or commenting on the PR, or whatever else we deem suitable) even if it does detect an increase?

Copy link
Member Author

@nashif nashif Oct 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephanosio

FWIW, there exists zephyr-runner-linux-x64-xlarge, which has 4 vCPUs instead of 16 -- we likely do not need 16 vCPUs for these workflows.

changed to that runner now, and as suspected, it does not launch...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephanosio

FWIW, there exists zephyr-runner-linux-x64-xlarge, which has 4 vCPUs instead of 16 -- we likely do not need 16 vCPUs for these workflows.

changed to that runner now, and as suspected, it does not launch...

Isn't this because the use of these runners is somewhat protected? You want to avoid that anybody can use them.
I typically see a
if: github.repository_owner == 'zephyrproject-rtos'
before using them
Not sure how this is enforced though.

kartben
kartben previously approved these changes Oct 11, 2023
looks like our docker image is way too big for the GH runners, so move
to own runners until we have a better solution.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
Copy link
Member Author

nashif commented Oct 17, 2023

swithcing back to 4xlarge until xlarge builders are available again.

@nashif nashif added this to the v3.5.0 milestone Oct 17, 2023
@jhedberg jhedberg assigned jhedberg and unassigned stephanosio Oct 17, 2023
@jhedberg jhedberg merged commit 3b9acef into zephyrproject-rtos:main Oct 17, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants