-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: move footprint workflows to zephyr runners #63781
ci: move footprint workflows to zephyr runners #63781
Conversation
@@ -22,7 +22,7 @@ concurrency: | |||
|
|||
jobs: | |||
footprint-tracking: | |||
runs-on: ubuntu-22.04 | |||
runs-on: zephyr-runner-linux-x64-4xlarge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, there exists zephyr-runner-linux-x64-xlarge
, which has 4 vCPUs instead of 16 -- we likely do not need 16 vCPUs for these workflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last time I checked those were not working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and it runs "only" twice a day anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one, yes. But we also have a PR related action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. And is it really useful, btw? If I'm not mistaken it's not setting the diff as a "build output" (hence making it cumbersome to quickly go and look for the information in the job), and, more importantly, it's not really failing (or commenting on the PR, or whatever else we deem suitable) even if it does detect an increase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, there exists
zephyr-runner-linux-x64-xlarge
, which has 4 vCPUs instead of 16 -- we likely do not need 16 vCPUs for these workflows.
changed to that runner now, and as suspected, it does not launch...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, there exists
zephyr-runner-linux-x64-xlarge
, which has 4 vCPUs instead of 16 -- we likely do not need 16 vCPUs for these workflows.changed to that runner now, and as suspected, it does not launch...
Isn't this because the use of these runners is somewhat protected? You want to avoid that anybody can use them.
I typically see a
if: github.repository_owner == 'zephyrproject-rtos'
before using them
Not sure how this is enforced though.
81dc826
to
267b56c
Compare
looks like our docker image is way too big for the GH runners, so move to own runners until we have a better solution. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
267b56c
to
7c5af47
Compare
swithcing back to 4xlarge until xlarge builders are available again. |
looks like our docker image is way too big for the GH runners, so move
to own runners until we have a better solution.
Signed-off-by: Anas Nashif anas.nashif@intel.com