Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: move footprint workflows to zephyr runners #63781

Merged
merged 1 commit into from
Oct 17, 2023
Merged

ci: move footprint workflows to zephyr runners #63781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/footprint-tracking.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ concurrency:

jobs:
footprint-tracking:
runs-on: ubuntu-22.04
runs-on: zephyr-runner-linux-x64-4xlarge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, there exists zephyr-runner-linux-x64-xlarge, which has 4 vCPUs instead of 16 -- we likely do not need 16 vCPUs for these workflows.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last time I checked those were not working.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and it runs "only" twice a day anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one, yes. But we also have a PR related action.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. And is it really useful, btw? If I'm not mistaken it's not setting the diff as a "build output" (hence making it cumbersome to quickly go and look for the information in the job), and, more importantly, it's not really failing (or commenting on the PR, or whatever else we deem suitable) even if it does detect an increase?

Copy link
Member Author

@nashif nashif Oct 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephanosio

FWIW, there exists zephyr-runner-linux-x64-xlarge, which has 4 vCPUs instead of 16 -- we likely do not need 16 vCPUs for these workflows.

changed to that runner now, and as suspected, it does not launch...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephanosio

FWIW, there exists zephyr-runner-linux-x64-xlarge, which has 4 vCPUs instead of 16 -- we likely do not need 16 vCPUs for these workflows.

changed to that runner now, and as suspected, it does not launch...

Isn't this because the use of these runners is somewhat protected? You want to avoid that anybody can use them.
I typically see a
if: github.repository_owner == 'zephyrproject-rtos'
before using them
Not sure how this is enforced though.

if: github.repository_owner == 'zephyrproject-rtos'
container:
image: ghcr.io/zephyrproject-rtos/ci:v0.26.5
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/footprint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ concurrency:

jobs:
footprint-delta:
runs-on: ubuntu-22.04
runs-on: zephyr-runner-linux-x64-4xlarge
if: github.repository == 'zephyrproject-rtos/zephyr'
container:
image: ghcr.io/zephyrproject-rtos/ci:v0.26.5
Expand Down