Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: dptechnics: Add support for Walter board #73351

Merged
merged 1 commit into from
Sep 17, 2024
Merged

boards: dptechnics: Add support for Walter board #73351

merged 1 commit into from
Sep 17, 2024

Conversation

vThibo
Copy link
Contributor

@vThibo vThibo commented May 27, 2024 •
edited by kartben
Loading

This PR adds support for DPTechnics Walter, a compact IoT development board combining an ESP32-S3 with a Sequans Monarch 2 GM02SP cellular modem.
Definitions are based on the other ESP32-S3 boards and includes the necessary modifications to quickly get started with the modem subsystem and modem_cellular driver.

https://builds.zephyrproject.io/zephyr/pr/73351/docs/boards/dptechnics/walter/doc/index.html

@vThibo vThibo force-pushed the feat-boards-walter branch 4 times, most recently from 3b428ec to 144e3ea Compare May 27, 2024 14:46
@vThibo vThibo marked this pull request as ready for review May 28, 2024 08:52
@MaureenHelm MaureenHelm added the platform: ESP32 Espressif ESP32 label Jun 12, 2024
@sylvioalves
Copy link
Collaborator

@vThibo Thanks for the contribution. I missed this review before.

@vThibo
Copy link
Contributor Author

vThibo commented Jun 14, 2024

@vThibo Thanks for the contribution. I missed this review before.

No problem, thanks for the review suggestions.

kartben
kartben requested changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor feedback regarding the documentation
Thanks for the PR!

boards/dptechnics/walter/doc/img/board.jpg Outdated Show resolved Hide resolved
boards/dptechnics/walter/doc/img/pinout.jpg Outdated Show resolved Hide resolved
boards/dptechnics/walter/doc/index.rst Outdated Show resolved Hide resolved
boards/dptechnics/walter/doc/index.rst Outdated Show resolved Hide resolved
kartben
kartben requested changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor feedback regarding the documentation
Thanks for the PR!

@vThibo
Copy link
Contributor Author

vThibo commented Jun 14, 2024

some minor feedback regarding the documentation Thanks for the PR!

Thanks for the feedback!

@vThibo vThibo force-pushed the feat-boards-walter branch 2 times, most recently from a2f0f46 to 4e3a2e1 Compare June 14, 2024 10:00
sylvioalves
sylvioalves previously approved these changes Jun 14, 2024
View reviewed changes
marekmatej
marekmatej previously approved these changes Jun 14, 2024
View reviewed changes
kartben
kartben previously approved these changes Jun 14, 2024
View reviewed changes
@kartben
Copy link
Collaborator

kartben commented Jun 14, 2024

@sylvioalves @marekmatej the CI failure with LZ4 sounds vaguely familiar, does this ring a bell and do you know what needs to be changed to make it pass?

@marekmatej
Copy link

@sylvioalves @marekmatej the CI failure with LZ4 sounds vaguely familiar, does this ring a bell and do you know what needs to be changed to make it pass?

I remember rebasing and push again did the trick for me.

@sylvioalves
Copy link
Collaborator

@vThibo Sounds error is related to this:

devicetree error: 'bus-speed' is marked as deprecated in 'properties:' in /__w/zephyr/zephyr/dts/bindings/can/espressif,esp32-twai.yaml for node /soc/can@6002b000.

Would you check it?

@vThibo vThibo dismissed stale reviews from kartben, marekmatej, and sylvioalves via ca6677e June 24, 2024 09:25
@vThibo vThibo requested a review from sylvioalves June 24, 2024 09:31
@MaureenHelm
Copy link
Member

@sylvioalves please revisit

kartben
kartben requested changes Aug 8, 2024
View reviewed changes
boards/dptechnics/walter/doc/index.rst Outdated Show resolved Hide resolved
@vThibo
Copy link
Contributor Author

vThibo commented Sep 9, 2024

Apologies for the delayed response. Tested on upstream, let me know if a rebase is needed.

@vThibo vThibo requested a review from kartben September 9, 2024 15:31
kartben
kartben requested changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spotted one more issue in the docs -- lgtm otherwise but need @sylvioalves and other Espressif folks to chime in

boards/dptechnics/walter/doc/index.rst Outdated
Comment on lines 154 to 156
```
CONFIG_BOOTLOADER_MCUBOOT=y
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #75239
@sylvioalves if you know, you know :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vThibo, please convert the above to:

   .. code:: cfg
      CONFIG_BOOTLOADER_MCUBOOT=y

@sylvioalves
Copy link
Collaborator

Overall LGTM, waiting for last doc update.

kartben
kartben requested changes Sep 15, 2024
View reviewed changes
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#78304 will require you to do these two updates to how hello_world is referenced. I am hoping it will land on Monday or Tuesday so you will then need to rebase

boards/dptechnics/walter/doc/index.rst Outdated Show resolved Hide resolved
boards/dptechnics/walter/doc/index.rst Outdated Show resolved Hide resolved
@vThibo vThibo force-pushed the feat-boards-walter branch 2 times, most recently from 497b42a to 0ae954b Compare September 17, 2024 11:46
@vThibo
boards: dptechnics: Add support for Walter board
4186fbb 
Add board definitions for the DPTechnics Walter board.

Signed-off-by: Thibo Verheyde <thibo@dptechnics.com>
@vThibo
Copy link
Contributor Author

vThibo commented Sep 17, 2024

Changed docs with feedback and small reference change.
Now also using the generic purpose partition tables added in #76976.

@nashif nashif merged commit 91535f3 into zephyrproject-rtos:main Sep 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daanpape daanpape daanpape left review comments

@sylvioalves sylvioalves sylvioalves approved these changes

@kartben kartben kartben approved these changes

@marekmatej marekmatej marekmatej left review comments

@nashif nashif Awaiting requested review from nashif

@LucasTambor LucasTambor Awaiting requested review from LucasTambor

Assignees

@sylvioalves sylvioalves

Labels
platform: ESP32 Espressif ESP32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vThibo @sylvioalves @kartben @marekmatej @MaureenHelm @daanpape @nashif