Bluetooth: Audio: Rename bt_audio_codec_qos -> bt_bap_qos_cfg #76633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
Release Notes
zephyrbot
requested review from
aescolar,
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
hermabe,
jhedberg,
kartben,
kruithofa,
larsgk,
MariuszSkamra,
nashif,
niym-ot,
pin-zephyr,
sjanc and
Vudentz
kruithofa
reviewed
Aug 9, 2024
Comment on lines
+252
to
+264
| * Unlike the other fields, this is not a preference but a minimum requirement. | ||
| * | ||
| * Value range 0 to @ref BT_AUDIO_PD_MAX, or @ref BT_AUDIO_PD_PREF_NONE | ||
| * to indicate no preference. |
There was a problem hiding this comment.
The documentation for the presentation delay fields seem wrong. Although fixing this is not strictly part of this PR it may as well be done here, instead of creating a separate PR for fixing it.
Suggested change
| * Unlike the other fields, this is not a preference but a minimum requirement. | |
| * | |
| * Value range 0 to @ref BT_AUDIO_PD_MAX, or @ref BT_AUDIO_PD_PREF_NONE | |
| * to indicate no preference. | |
| * Unlike the other fields, this is not a preference but a minimum requirement. | |
| * | |
| * Value range 0 to @ref BT_AUDIO_PD_MIN |
include/zephyr/bluetooth/audio/bap.h
Outdated
| /** | ||
| * @brief Preferred minimum Presentation Delay | ||
| * | ||
| * Value range 0 to @ref BT_AUDIO_PD_MAX. |
There was a problem hiding this comment.
Suggested change
| * Value range 0 to @ref BT_AUDIO_PD_MAX. | |
| * Value range pd_min to pref_pd_max, or @ref BT_AUDIO_PD_PREF_NONE | |
| * to indicate no preference. |
Comment on lines
+264
to
+274
| * Value range 0 to @ref BT_AUDIO_PD_MAX, or @ref BT_AUDIO_PD_PREF_NONE | ||
| * to indicate no preference. |
There was a problem hiding this comment.
Suggested change
| * Value range 0 to @ref BT_AUDIO_PD_MAX, or @ref BT_AUDIO_PD_PREF_NONE | |
| * to indicate no preference. | |
| * Value range 0 to @ref BT_AUDIO_PD_MAX |
include/zephyr/bluetooth/audio/bap.h
Outdated
| /** | ||
| * @brief Preferred maximum Presentation Delay | ||
| * | ||
| * Value range 0 to @ref BT_AUDIO_PD_MAX. |
There was a problem hiding this comment.
Suggested change
| * Value range 0 to @ref BT_AUDIO_PD_MAX. | |
| * Value range pref_pd_min to px_max, or @ref BT_AUDIO_PD_PREF_NONE | |
| * to indicate no preference. |
include/zephyr/bluetooth/audio/bap.h
Outdated
| uint32_t pd_min; | ||
|
|
||
| /** | ||
| * @brief Maximum Presentation Delay |
There was a problem hiding this comment.
Suggested change
| * @brief Maximum Presentation Delay | |
| * @brief Maximum Presentation Delay in microseconds |
include/zephyr/bluetooth/audio/bap.h
Outdated
| uint32_t pd_max; | ||
|
|
||
| /** | ||
| * @brief Preferred minimum Presentation Delay |
There was a problem hiding this comment.
Suggested change
| * @brief Preferred minimum Presentation Delay | |
| * @brief Preferred minimum Presentation Delay in microseconds |
include/zephyr/bluetooth/audio/bap.h
Outdated
| uint32_t pref_pd_min; | ||
|
|
||
| /** | ||
| * @brief Preferred maximum Presentation Delay |
There was a problem hiding this comment.
Suggested change
| * @brief Preferred maximum Presentation Delay | |
| * @brief Preferred maximum Presentation Delay in microseconds |
|
@kruithofa would prefer not to modify more than necessary in this PR. It will likely conflict with #75763 and once one of them is one, I can update the remaining PR with your comments. |
kruithofa
previously approved these changes
Aug 14, 2024
|
Rebased to solve merge conflicts |
zephyrbot
added
the
area: Bluetooth Qualification
kruithofa
previously approved these changes
Aug 15, 2024
Thalley
force-pushed
the
qos_cfg_rename
branch
from
5498008
to
b078644
Compare
|
Rebased to fix merge conflicts |
kruithofa
previously approved these changes
Sep 3, 2024
Thalley
force-pushed
the
qos_cfg_rename
branch
from
b078644
to
2f9d7ff
Compare
kruithofa
previously approved these changes
Sep 5, 2024
Thalley
force-pushed
the
qos_cfg_rename
branch
from
2f9d7ff
to
bf1873f
Compare
|
Rebased to solve merge conflicts |
kruithofa
previously approved these changes
Sep 9, 2024
|
Rebased to solve merge conflicts |
Thalley
force-pushed
the
qos_cfg_rename
branch
from
bf1873f
to
91a22a5
Compare
Thalley
force-pushed
the
qos_cfg_rename
branch
from
91a22a5
to
4f07a80
Compare
|
Rebased to solve merge conflicts |
kruithofa
previously approved these changes
Sep 24, 2024
The QoS structure is not related to a codec, but rather a stream, and should thus not use the "Codec" name. The BAP and ASCS specs refer to the QoS as "QoS configuration" several places, so it is an obvious choice for a name. Since the structure is defined and used by BAP, the prefix was changed from bt_audio to bt_bap. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Thalley
force-pushed
the
qos_cfg_rename
branch
from
4f07a80
to
750874b
Compare
|
Rebased to solve merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The QoS structure is not related to a codec, but rather a stream, and should thus not use the "Codec" name.
The BAP and ASCS specs refer to the QoS as
"QoS configuration" several places, so it is an obvious choice for a name.
Since the structure is defined and used by BAP, the prefix was changed from bt_audio to bt_bap.
fixes #72684