usb: fix wrong capacity report for USB mass storage device #77597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usb "write" method never copies the input data buffer, it uses the buffer pointer directly. The fact that it was on the stack made the buffer ephemeral, and could disappear before the USB transfer actually occurred. The data transmitted was then random. This commit converts the transfer buffer to a static buffer, so that it always exists for the duration of the USB transfer. Known side-effect: if "read capacity" command is read twice simultaneously, the same buffer will be used twice. As the capacity of a USB drive should not change between 2 calls, this side effect can be ignored. Signed-off-by: Alexi Demers <alexi.demers@axceta.com> (cherry picked from commit 32481b6)
zephyrbot
added
size: XS
tmon-nordic
approved these changes
Aug 27, 2024
carlescufi
approved these changes
Oct 2, 2024
fabiobaltieri
merged commit b26773f
into
zephyrproject-rtos:v3.7-branch
29 of 31 checks passed
jfischer-no
deleted the
pr-backport-32481b64185205222a58acdc6e7272ef2c06869d
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-picked 32481b6 from #77173
Fixes #77175.