Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usb: fix wrong capacity report for USB mass storage device #77597

Commits on Aug 27, 2024

  1. usb: fix wrong capacity report for USB mass storage device

    Usb "write" method never copies the input data buffer, it uses the
    buffer pointer directly. The fact that it was on the stack made
    the buffer ephemeral, and could disappear before the USB transfer
    actually occurred. The data transmitted was then random. This commit
    converts the transfer buffer to a static buffer, so that it always
    exists for the duration of the USB transfer.
    
    Known side-effect: if "read capacity" command is read twice
    simultaneously, the same buffer will be used twice. As the capacity of a
    USB drive should not change between 2 calls, this side effect can be
    ignored.
    
    Signed-off-by: Alexi Demers <alexi.demers@axceta.com>
    (cherry picked from commit 32481b6)
    ademers-axceta authored and jfischer-no committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    3c4fe42 View commit details
    Browse the repository at this point in the history