samples: hello_world: use zephyr:code-sample directive #78304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
butok,
danieldegrasse,
decsny,
DerekSnell,
dleach02,
EmilioCBen,
erwango,
FRASTM,
gautierg-st,
GeorgeCGV,
marwaiehm-st,
mathieuchopstm,
mmahadevan108 and
yvanderv
rerickson1
previously approved these changes
Sep 12, 2024
erwango
previously approved these changes
Sep 12, 2024
kartben
force-pushed
the
hello_world_code_sample_directive
branch
from
078e7d0
to
f86ed69
Compare
kartben
force-pushed
the
hello_world_code_sample_directive
branch
from
f86ed69
to
f6c9be9
Compare
|
rebased on main to address recent boards' READMEs referencing hello world the "old" way |
|
Oops, will rebase once more when Hotfix for docs currently broken on main will get merged |
kartben
force-pushed
the
hello_world_code_sample_directive
branch
from
f6c9be9
to
b23f3ce
Compare
fixed some ReST/Sphinx lint issues missed in earlier cleanups prior to introducing Sphinx-linter in compliance check Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
Adds missing code-sample directive to the Hello World sample in preparation for upcoming changes to the Zephyr documentation that will be leveraging the provided description and metadata. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
kartben
force-pushed
the
hello_world_code_sample_directive
branch
from
b23f3ce
to
117a483
Compare
|
Re-assigned to myself as this is 100% docs/samples stuff |
kartben
requested review from
nashif,
rerickson1,
erwango and
Thalley
and removed request for
rerickson1,
erwango and
nashif
Thalley
approved these changes
Sep 15, 2024
henrikbrixandersen
approved these changes
Sep 15, 2024
jhedberg
approved these changes
Sep 15, 2024
ubieda
approved these changes
Sep 15, 2024
dkalowsk
approved these changes
Sep 15, 2024
aescolar
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing code-sample directive to the Hello World sample in preparation for upcoming changes to the Zephyr documentation that will be leveraging the provided description and metadata.
This obviously touches many files but the only actual change is the addition of the directive to the hello world sample:
First commit is some trivial Sphinx lint fixes.