cmake: dts: Use temporary file for dts.cmake #81340
Open
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nordicjm
commented
Nov 13, 2024
•
nordicjm
commented
tejlmand
requested changes
Nov 13, 2024
nordicjm
force-pushed
the
sbdtsfile
branch
2 times, most recently
from
f230669
to
43cac1d
Compare
tejlmand
previously approved these changes
Nov 14, 2024
cmake/modules/dts.cmake
Outdated
Comment on lines
352
to
355
| # A temporary file is used copied to the original file if it differs, this prevents a cycle when | ||
| # sysbuild is used of configuring and building multiple times due to the dts.cmake file of images | ||
| # having a newer modification time than the sysbuild build.ninja file, despite the output having | ||
| # not changed |
There was a problem hiding this comment.
In general this is not only tied to sysbuild.
Touching any file during CMake configure time can trigger additional build steps later.
Build steps which may be unnecessary if there are no changes to the configure time generated file.
This may not only be related to dts.cmake, but can be true for other files created at configure time.
Therefore this is not fixing a sysbuild issue, sysbuild just happens to be impacted more by this fact than other parts of the system.
Long term a more general handling of such cases would be nice so that we don't regenerate a file in the first place instead of having to generate, compare and move.
57300
reviewed
Nov 14, 2024
nordicjm
changed the title
57300
previously approved these changes
Nov 14, 2024
tejlmand
previously approved these changes
Nov 14, 2024
Uses a temporary file for dts output then uses CMake to copy to the correct file if it has changed. This prevents a ping-pong issue when sysbuild is used of configuring and building cycle when nothing has changed and there is sysbuild code which loads in the devicetree data from an image Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
57300
approved these changes
Nov 15, 2024
tejlmand
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.