generate empty collections for missing fields #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe. |
987Nabil
requested changes
Sep 17, 2024
| @@ -534,6 +535,7 @@ object Schema extends SchemaPlatformSpecific with SchemaEquality { | |||
|
|
|||
| override def toString: String = s"Sequence($elementSchema, $identity)" | |||
|
|
|||
| override def empty: Col = Seq.empty[Elem].asInstanceOf[Col] | |||
There was a problem hiding this comment.
This will throw except Col == List. Correct should be
Suggested change
| override def empty: Col = Seq.empty[Elem].asInstanceOf[Col] | |
| override def empty: Col = fromChunk(Chunk.empty[Elem]) |
There was a problem hiding this comment.
Please add a test for this case too
juliano
force-pushed
the
missing-field-as-empty-collection
branch
from
aab983f
to
64050bd
Compare
987Nabil
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/fixes #664
/closes #664
/claim #664