Merge branch 'dev' into dev-history_first_ticket

znuny · Mar 29, 2023 · f468aad · f468aad
2 parents 0f49664 + c0be0aa
commit f468aad
Show file tree

Hide file tree

Showing 304 changed files with 25,673 additions and 36,884 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -48,27 +48,6 @@ jobs:
           git init
           "${GITHUB_WORKSPACE}/codepolicy/bin/znuny.CodePolicy.pl" --all-files --mode ci
 
-  CPANAudit:
-    name: CPANAudit
-    runs-on: ubuntu-latest
-    container: debian:10-slim
-    steps:
-      - name: Check out repository code
-        uses: actions/checkout@v3
-        env:
-          fetch-depth: "1"
-
-      - name: Install dependencies
-        run: .github/workflows/ci/dependencies.sh
-
-      - name: Setup Znuny
-        run: .github/workflows/ci/setup.sh
-
-      - name: Check CPANAudit
-        run: |
-          su -c "bin/otrs.Console.pl Dev::Code::CPANAudit" - otrs
-          exit $?
-
   Contributors:
     name: Contributors
     runs-on: ubuntu-latest
@@ -228,7 +207,6 @@ jobs:
     container: debian:10-slim
     needs: [
       ZnunyCodePolicy,
-      CPANAudit,
       Contributors,
       Database-Schema,
       Database-InitialInsert,

diff --git a/.mailmap b/.mailmap
@@ -28,6 +28,7 @@ Jens Bothe <jens.bothe@otrs.com> jensoliver <jojo@jbothe.de>
 Jens Pfeifer <jp@znuny.com> Jens Pfeifer <jens.pfeifer@otrs.com>
 Jens Pfeifer <jp@znuny.com> Jens Pfeifer <jens.pfeifer@znuny.com>
 Jens Pfeifer <jp@znuny.com> Jens Pfeifer <mail@jenspfeifer.de>
+Kai Herlemann <kh@znuny.com> Kai Herlemann <43746520+KaiHerlemann@users.noreply.github.com>
 Kamil Furtek <kfurtek@dev.opgksoftware.com> Kamil Furtek <kfurtek@opgksoftware.com>
 Kevin Janssen <77158891+BuTzZ@users.noreply.github.com> root <k.janssen@posteo.de>
 Konrad Gumienny <kgumienny@dev.opgksoftware.com> Konrad <kgumienny@dev.opgksoftware.com>
@@ -94,6 +95,7 @@ tipue <tim.puettmanns@maxence.de> tipue <80031303+tipue-dev@users.noreply.github
 # Assign unknown entries to anonymous
 Znuny Weblate <do-not-reply@znuny.com> Weblate Admin <operations@znuny.com>
 Znuny Weblate <do-not-reply@znuny.com> Weblate <noreply@weblate.org>
+Znuny Weblate <do-not-reply@znuny.com> ZnunyWeblate <rk+weblate@znuny.com>
 anonymous <unknown@anonymous> atif <>
 anonymous <unknown@anonymous> nicolas <>
 anonymous <unknown@anonymous> otrsintern <otrsintern@gmail.com>

diff --git a/AUTHORS.md b/AUTHORS.md
@@ -15,6 +15,8 @@ The following persons contributed to Znuny:
 * Carlos Rodriguez <carlos.rodriguez@otrs.com>
 * Christian Schöpplein <christian.schoepplein@otrs.com>
 * Christopher T. Kuhn <christopher.kuhn@otrs.com>
+* Daniel Lisiecki <lisiecki.daniel@gmail.com>
+* Daniel Sprenger <123074686+sprengerdaniel@users.noreply.github.com>
 * Daniel Zamorano <daniel.zamorano@otrs.com>
 * David Crimi <deathpoison.dc@gmail.com>
 * Denis Nelubin <dnelubin@gmail.com>
@@ -43,7 +45,7 @@ The following persons contributed to Znuny:
 * Jens Pfeifer <jp@znuny.com>
 * Johannes Hörburger <johannes.hoerburger@otrs.com>
 * Johannes Nickel <jn@znuny.com>
-* Kai Herlemann <43746520+KaiHerlemann@users.noreply.github.com>
+* Kai Herlemann <kh@znuny.com>
 * Kamil Furtek <kfurtek@dev.opgksoftware.com>
 * Keith Moore <tenareth@gmail.com>
 * Kevin Janssen <77158891+BuTzZ@users.noreply.github.com>

diff --git a/CHANGES.md b/CHANGES.md
@@ -1,13 +1,38 @@
-# 6.5.1 2023-??-??
+# 6.5.2 2023-??-??
+ - 2023-03-16 Added Appointment::EventModulePost Entry in XML. Thanks to Kevin Janssen (@BuTzZ). [PR#315](https://github.com/znuny/Znuny/pull/315)
+ - 2023-03-10 Fixed notification about empty subject for article drafts in AgentTicketCompose and AgentTicketEmailOutbound.
+
+# 6.5.1 2023-03-09
+ - 2023-02-28 Added options tickets-created-before-date and tickets-created-before-days to console command Admin::Article::StorageSwitch.
+ - 2023-02-28 Fixed encoding of postmaster filter name in AdminPostMasterFilter.
+ - 2023-02-28 Fixed encoding of profile name in AdminGenericAgent.
+ - 2023-02-23 Fixed "Inline images in drafts will not display for more than 24 hours". [#309](https://github.com/znuny/Znuny/issues/309)
+ - 2023-02-21 Fixed - Agent Calendar Import: Import of a calendar file does not work.
+ - 2023-02-20 Removed maxlength for field short description in ActivityDialog (#335). Thanks to Sector Nord AG (@paulfolkers). [PR#335](https://github.com/znuny/Znuny/pull/335)
+ - 2023-02-17 Moved code of ITSMIncidentProblemManagement to Znuny Framework that will only be executed if ITSM actually is installed.
+ - 2023-02-17 Removed CPAN::Audit as a required Perl module.
+ - 2023-02-16 Integrated package Znuny-NoteToLinkedTicket.
+ - 2023-02-13 Added support for smart tags to process activity dialog article field.
+ - 2023-01-25 Added Dashboard element filter: My owned tickets.
+ - 2023-01-23 Added new event module to store customer company data in ticket dynamic fields: Ticket::EventModulePost DynamicFieldFromCustomerCompany.
+ - 2023-01-23 Sort screens in AdminDynamicFieldScreenConfiguration by values (#327). Thanks to Emin Yazi (@eyazi), Efflux. [PR#327](https://github.com/znuny/Znuny/pull/327)
+ - 2023-01-20 Added SysConfig setting to configure format tags in rich text editor. Thanks to Daniel Sprenger (@sprengerdaniel). [PR#334](https://github.com/znuny/Znuny/pull/334)
+ - 2023-01-20 Fixed "NoPermission" screen to use "CustomerNoPermission" for ACL checking. Thanks to Sector Nord AG (@paulfolkers). [PR#333](https://github.com/znuny/Znuny/pull/333)
+ - 2023-01-20 Fixed reloading of the toolbar modules. Thanks to Tim Püttmanns (@tipue-dev), maxence. [PR#317](https://github.com/znuny/Znuny/pull/317)
+ - 2023-01-20 Fixed hidden TicketOverview filters for Medium and Preview. Thanks to Tim Püttmanns (@tipue-dev), maxence. [PR#301](https://github.com/znuny/Znuny/pull/301)
+ - 2023-01-20 Fixed uninitialized value warning in AdminSystemMaintenance. Thanks to Tim Püttmanns (@tipue-dev), maxence. [PR#298](https://github.com/znuny/Znuny/pull/298)
+ - 2023-01-12 Fixed use of unavailable CKEditor autocomplete plugin when editor is in "CodeMirror" mode (e.g. web service XSLT configuration dialog).
+ - 2023-01-10 JavaScript code will now be removed from href attributes in function Kernel::System::HTMLUtils::ToAscii. Thanks for hints to Tim Püttmanns, maxence.
  - 2023-01-10 Sector Nord AG: Fixed popup description long were cut off in Customer Interface. Thanks to Sector Nord AG (@jsinagowitz). [PR#331](https://github.com/znuny/Znuny/pull/331)
  - 2023-01-09 Integrated package Znuny4OTRS-UserMaxArticlesPerPage.
  - 2023-01-06 Fixed 'ACL misbehaviour in processes' - ActivityEntityID is missing in AgentTicketProcess.pm. [#316](https://github.com/znuny/Znuny/issues/316)
+ - 2023-01-05 Added missing group check to Kernel/System/Auth/Sync/LDAP.pm.
  - 2023-01-05 Fixed JavaScript error in edit-mode in AdminACL.
- - 2023-01-05 Changed JS alert() function to Core.UI.Dialog.ShowAlert().
- - 2023-01-04 Show PackageRequired- and ModuleRequired-information while package installation & update.
+ - 2023-01-05 Changed JS alert function to Core.UI.Dialog.ShowAlert.
+ - 2023-01-04 Show PackageRequired and ModuleRequired information while package installation and update.
  - 2023-01-04 Reworked information of LastViews.
  - 2023-01-03 Process activity dialog article fields with subject and body can now be pre-filled. The Body also support RichtText. Thanks to Berner Fachhochschule (bfh.ch) for sponsoring this feature.
- - 2022-12-29 Reenabled TicketID for reporting (Dynamic/TicketList).
+ - 2022-12-29 Re-enabled TicketID for reporting (Dynamic/TicketList).
  - 2022-12-19 Added check for maximum filename length to file uploads.
  - 2022-12-16 Added new function Kernel::System::Web::Request::GetParams() to get request parameters.
  - 2022-12-13 Fixed SQL injection in TicketSearch.pm (CVE-2022-4427). Thanks for hints to Tim Püttmanns, maxence.
@@ -18,6 +43,7 @@
  - 2022-11-25 Moved code of ITSMCore to Znuny Framework that will only be executed if ITSM actually is installed.
  - 2022-11-24 Fixed handling of empty result for frontend autocompletion of dynamic field type WebserviceMultiselect.
  - 2022-11-24 SOAP::Lite: Data of elements with attribute 'xsi:type' now will be returned as a hash or array instead of an arbitrary object that Znuny cannot handle.
+ - 2022-09-20 Added config level check to SysConfig admin dialog. Thanks for hints to Tim Püttmanns, maxence.
  - 2022-09-16 Auto responses now will not be sent if the recipient would be a system address.
 
 # 6.4.5 2022-12-20
@@ -36,7 +62,7 @@
  - 2022-10-12 S/MIME certificates will now be reindexed during Znuny migration.
  - 2022-10-12 Increased size of column "subject" of table "smime_keys".
  - 2022-10-11 Added input field for OAuth2 token scope to admin dialog.
- - 2022-10-07 Integrate DashboardMyLastChangedTickets. Thanks to Renée Bäcker (@reneeb). [PR#177](https://github.com/znuny/Znuny/pull/177)
+ - 2022-10-07 Integrated DashboardMyLastChangedTickets. Thanks to Renée Bäcker (@reneeb). [PR#177](https://github.com/znuny/Znuny/pull/177)
  - 2022-10-07 Renamed changed settings from FrontendRichText::Path to Frontend::RichText::Path. Thanks to Emin Yazi (@eyazi), Efflux. Thanks to Tim Püttmanns (@tipue-dev), maxence. [PR#304](https://github.com/znuny/Znuny/pull/304)
  - 2022-10-05 Improved usability - AgentTicketBulk - Set DynamicField_NAMEUsed checkbox to true if it is set before or if dynamic field is mandatory.
  - 2022-09-29 Fixed bug - hour 0 is not possible in the default settings for TimeWorkingHours. Thanks to Sector Nord AG (@LuBroering - Lukas Bröring). [PR#296](https://github.com/znuny/Znuny/pull/296)

diff --git a/Kernel/Config/Defaults.pm b/Kernel/Config/Defaults.pm
@@ -531,6 +531,7 @@ sub LoadDefaults {
 #    $Self->{'AuthSyncModule::LDAP::Host'} = 'ldap.example.com';
 #    $Self->{'AuthSyncModule::LDAP::BaseDN'} = 'dc=example,dc=com';
 #    $Self->{'AuthSyncModule::LDAP::UID'} = 'uid';
+#    $Self->{'AuthSyncModule::LDAP::GroupDN'} = 'cn=otrsallow,ou=posixGroups,dc=example,dc=com';
 
     # The following is valid but would only be necessary if the
     # anonymous user do NOT have permission to read from the LDAP tree
@@ -1750,7 +1751,7 @@ via the Preferences button after logging in.
         NavBarName => 'Admin',
         Title      => '',
     };
-    $Self->{'Loader::Module::Admin'}->{'000-Defaults'} = {
+    $Self->{'Loader::Module::Admin'}->{'001-Framework'} = {
         CSS => [
             'Core.Agent.Admin.css',
         ],
@@ -1808,7 +1809,7 @@ via the Preferences button after logging in.
         NavBarName => 'Admin',
         Title      => 'System Log',
     };
-    $Self->{'Loader::Module::AdminLog'}->{'000-Defaults'} = {
+    $Self->{'Loader::Module::AdminLog'}->{'001-Framework'} = {
         JavaScript => [
           'Core.Agent.Admin.Log.js'
         ],
@@ -1833,7 +1834,7 @@ via the Preferences button after logging in.
         Title        => 'System Configuration',
         NavBarName   => 'Admin',
     };
-    $Self->{'Loader::Module::AdminSystemConfiguration'}->{'000-Defaults'} = {
+    $Self->{'Loader::Module::AdminSystemConfiguration'}->{'001-Framework'} = {
         CSS => [
             'Core.Agent.Admin.SystemConfiguration.css',
         ],

diff --git a/Kernel/Config/Files/XML/Framework.xml b/Kernel/Config/Files/XML/Framework.xml
@@ -458,6 +458,13 @@
             <Item ValueType="String">Arial/Arial, Helvetica, sans-serif;Calibri/Calibri, sans-serif;Comic Sans MS/Comic Sans MS, cursive;Courier New/Courier New, Courier, monospace;Georgia/Georgia, serif;Lucida Sans Unicode/Lucida Sans Unicode, Lucida Grande, sans-serif;Tahoma/Tahoma, Geneva, sans-serif;Times New Roman/Times New Roman, Times, serif;Trebuchet MS/Trebuchet MS, Helvetica, sans-serif;Verdana/Verdana, Geneva, sans-serif</Item>
         </Value>
     </Setting>
+    <Setting Name="Frontend::RichText::Settings###FormatTags" Required="1" Valid="1">
+        <Description Translatable="1">Defines the selectable format tags in the rich text editor.</Description>
+        <Navigation>Frontend::Base</Navigation>
+        <Value>
+            <Item ValueType="String">p;h1;h2;h3;h4;h5;h6;pre</Item>
+        </Value>
+    </Setting>
     <Setting Name="Frontend::RichText::Settings###ExtraPlugins" Required="0" Valid="1">
         <Description Translatable="1">Defines additional plugins for use in the rich text editor.</Description>
         <Navigation>Frontend::Base</Navigation>
@@ -8571,7 +8578,6 @@ via the Preferences button after logging in.
                     <Item Key="Group">
                         <Array>
                             <Item>admin</Item>
-                            <Item>users</Item>
                         </Array>
                     </Item>
                     <Item Key="Description" Translatable="1">Manage System Configuration Deployments.</Item>
@@ -8654,7 +8660,6 @@ via the Preferences button after logging in.
                         <Item>Core.SystemConfiguration.VacationDays.js</Item>
                         <Item>Core.SystemConfiguration.VacationDaysOneTime.js</Item>
                         <Item>Core.SystemConfiguration.WorkingHours.js</Item>
-                        <Item>Core.Form.js</Item>
                         <Item>Core.Agent.Admin.SystemConfiguration.js</Item>
                     </Array>
                 </Item>
@@ -8737,7 +8742,6 @@ via the Preferences button after logging in.
                         <Item>Core.SystemConfiguration.VacationDays.js</Item>
                         <Item>Core.SystemConfiguration.VacationDaysOneTime.js</Item>
                         <Item>Core.SystemConfiguration.WorkingHours.js</Item>
-                        <Item>Core.Form.js</Item>
                         <Item>Core.Agent.Admin.SystemConfiguration.js</Item>
                     </Array>
                 </Item>

diff --git a/Kernel/Config/Files/XML/GenericInterface.xml b/Kernel/Config/Files/XML/GenericInterface.xml
@@ -1,5 +1,16 @@
 <?xml version="1.0" encoding="utf-8"?>
 <otrs_config version="2.0" init="Application">
+    <Setting Name="AppointmentCalendar::EventModulePost###9900-GenericInterface" Required="0" Valid="1">
+        <Description Translatable="1">Performs the configured action for each event (as an Invoker) for each configured web service.</Description>
+        <Navigation>Core::Event::AppointmentCalendar</Navigation>
+        <Value>
+            <Hash>
+                <Item Key="Module">Kernel::GenericInterface::Event::Handler</Item>
+                <Item Key="Transaction">1</Item>
+                <Item Key="Event"></Item><!-- run on all events -->
+            </Hash>
+        </Value>
+    </Setting>
     <Setting Name="Ticket::EventModulePost###9900-GenericInterface" Required="0" Valid="1">
         <Description Translatable="1">Performs the configured action for each event (as an Invoker) for each configured web service.</Description>
         <Navigation>Core::Event::Ticket</Navigation>

diff --git a/Kernel/Config/Files/XML/ProcessManagement.xml b/Kernel/Config/Files/XML/ProcessManagement.xml
@@ -330,7 +330,6 @@
                 </Item>
                 <Item Key="JavaScript">
                     <Array>
-                        <Item>Core.Agent.CustomerSearch.js</Item>
                         <Item>Core.Agent.CustomerSearchAutoComplete.js</Item>
                         <Item>Core.Agent.TicketAction.js</Item>
                         <Item>Core.Agent.TicketProcess.js</Item>
@@ -507,7 +506,6 @@
                     <Array>
                         <Item>Core.TicketProcess.js</Item>
                         <Item>Core.Customer.TicketProcess.js</Item>
-                        <Item>Core.TicketProcess.js</Item>
                     </Array>
                 </Item>
             </Hash>