Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GenericInterface] 2FA was added #496

Closed
wants to merge 6 commits into from
Closed

Conversation

CallMeFlanby
Copy link
Contributor

@CallMeFlanby CallMeFlanby commented Sep 22, 2023

Proposed change

Added 2FA to the generic interface, allowing (but not forcing) by default the use of 2FA.
Currently, if an account has 2FA activated, this cannot be used with the REST API.
Not breaking change as users, that don't have 2FA will not be affected by this change.

Type of change

  • '1 - 🚀 feature' - New feature (which adds functionality to an existing integration)

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

@CallMeFlanby
Copy link
Contributor Author

Found issue #437 related to this.

@rkaldung
Copy link
Member

@CallMeFlanby I like this idea, but it should also work with the optional usage of HTTP headers. See https://github.com/znuny/Znuny/blob/dev/Kernel/GenericInterface/Transport/HTTP/REST.pm#L231

Can you add this to?

@rkaldung rkaldung added 1 - 🚀 feature New feature or request 3 - wait for contributor Contributor, it's your turn. labels Oct 13, 2023
@CallMeFlanby CallMeFlanby deleted the branch znuny:dev October 16, 2023 12:10
@CallMeFlanby CallMeFlanby deleted the dev branch October 16, 2023 12:10
@CallMeFlanby CallMeFlanby restored the dev branch October 16, 2023 12:11
@CallMeFlanby
Copy link
Contributor Author

@CallMeFlanby I like this idea, but it should also work with the optional usage of HTTP headers. See https://github.com/znuny/Znuny/blob/dev/Kernel/GenericInterface/Transport/HTTP/REST.pm#L231

Can you add this to?

I hope it was correct. Somehow however I had to create a new pull request after I changed the name of my branch. Please check #502 now.

@CallMeFlanby CallMeFlanby reopened this Oct 16, 2023
@dennykorsukewitz dennykorsukewitz removed the 3 - wait for contributor Contributor, it's your turn. label Nov 6, 2023
@CallMeFlanby CallMeFlanby deleted the dev branch November 9, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - 🚀 feature New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants