Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GenericInterface] 2FA was added #502

Merged
merged 19 commits into from
Apr 19, 2024

Conversation

CallMeFlanby
Copy link
Contributor

Proposed change

Added 2FA to the generic interface, allowing (but not forcing) by default the use of 2FA.
Currently, if an account has 2FA activated, this cannot be used with the REST API.
Not breaking change as users, that don't have 2FA will not be affected by this change.

Type of change

  • '1 - 🚀 feature' - New feature (which adds functionality to an existing integration)

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

@CallMeFlanby
Copy link
Contributor Author

CallMeFlanby commented Oct 16, 2023

@rkaldung
Updated version of pull request #496, that was closed due to branch refactor.

(#496 (comment))

@NiklasSchmitt NiklasSchmitt added the 1 - 🚀 feature New feature or request label Feb 22, 2024
@rkaldung rkaldung added the 4 - verified This issue or pull request was verified. label Mar 14, 2024
@rkaldung rkaldung requested a review from jepf March 14, 2024 06:31
@jepf jepf merged commit 77eedd2 into znuny:dev Apr 19, 2024
@jepf
Copy link
Contributor

jepf commented Apr 19, 2024

@CallMeFlanby

Thank you!

@CallMeFlanby
Copy link
Contributor Author

@CallMeFlanby

Thank you!

You're welcome. Please check, if the attached issue was then resolved. Have a wonderful weekend. 🤗

znuny-robo pushed a commit that referenced this pull request Apr 19, 2024
* [GenericInterface] 2FA was added

* Added optional usage of HTTP header

As recommended in the pull request

#502
---------

Co-authored-by: Denny Korsukéwitz <dennykorsukewitz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - 🚀 feature New feature or request 4 - verified This issue or pull request was verified.
Development

Successfully merging this pull request may close these issues.

5 participants