Use SurfaceFluxes.jl v0.8.0 #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaysridhar
added this to the O1.5.2b Refactor iteration methods and improve test coverage milestone
akshaysridhar
force-pushed
the
as/up-sf-version
branch
2 times, most recently
from
286f18c to
8e73d9a
Compare
szy21
approved these changes
Oct 19, 2023
trontrytel
approved these changes
Oct 20, 2023
Seems so - this is done in the latest commit. |
|
@sriharshakandala if you could verify the Project / Manifest toml updates w.r.t to the new SurfaceFluxes usage I can update the MSE tables via ref counter and merge this PR. |
akshaysridhar
force-pushed
the
as/up-sf-version
branch
from
6cbec69 to
9aab27d
Compare
|
The AMIP simulation in the longrun seems to break immediately. Could you reduce dt by a factor of 2? No need to wait to see whether it works, we can just wait for today's longrun. |
akshaysridhar
force-pushed
the
as/up-sf-version
branch
2 times, most recently
from
ac98ab2 to
9b3427e
Compare
Update sf functions to use v0.8.0 interface modified: Project.toml modified: docs/Manifest.toml modified: examples/Manifest.toml modified: perf/Manifest.toml modified: src/surface_conditions/surface_conditions.jl Update longrun configs to use Float32 Update patch version modified: Project.toml Bump ref counter 134 > 135 modified: regression_tests/ref_counter.jl Reduce longrun aquaplanet amip dt modified: config/longrun_configs/longrun_aquaplanet_amip.yml Update coupler compatibility test modified: test/coupler_compatibility.jl
akshaysridhar
force-pushed
the
as/up-sf-version
branch
from
9b3427e to
25150a8
Compare
1 task
|
bors r+ |
sriharshakandala
approved these changes
Oct 20, 2023
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This was referenced Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sf functions to use v0.8.0 interface
modified: Project.toml
modified: src/surface_conditions/surface_conditions.jl