🐛 [RUM-6567] Move performance namespace inside view #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethfowler-datadog
changed the title
BenoitZugmeyer
previously approved these changes
Jan 13, 2025
sethfowler-datadog
force-pushed
the
seth.fowler/move-performance-namespace-inside-view
branch
from
a433637 to
5c0ca10
Compare
thomas-lebeau
approved these changes
Jan 14, 2025
xgouchet
approved these changes
Jan 14, 2025
BenoitZugmeyer
approved these changes
Jan 14, 2025
sethfowler-datadog
deleted the
seth.fowler/move-performance-namespace-inside-view
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
performancenamespace added in #240 inside@view, to align better with the pattern we've followed in the past for fields that are only used in the context of a single event.Since we haven't yet landed the PRs that use the
performancenamespace in thebrowser-sdkrepo, it's still possible to make this change safely.