Tidy up I24 serial code

[noemifrisina]

• Remove unused code from setup_beamline
  (small note: modechange seems to be the change between goniometers. As I understand it, it's supposed to control a touch screen in the hutch that is currently broken. Keeping it in for the moment as beamline staff wants to get it working again. )
• Remove any legacy code that is not used anymore
• Remove unused edms/pvar files for unused chips
• General tidying up - remove/fix paths to avoid breaking things on the beamline
• Add script to set visit directory from the command line
• Add a couple more tests where possible

Closes #13
Closes #14 (...hopefully)

[codecov]

Codecov Report

Merging #16 (586ed84) into main (a7d496d) will increase coverage by 9.75%.
The diff coverage is 29.16%.

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   29.21%   38.96%   +9.75%     
==========================================
  Files          16       18       +2     
  Lines        3957     3585     -372     
==========================================
+ Hits         1156     1397     +241     
+ Misses       2801     2188     -613     

Impacted Files	Coverage Δ
...4/serial/fixed_target/i24ssx_Chip_Mapping_py3v1.py	12.59% <7.04%> (+5.90%)	⬆️
...4/serial/fixed_target/i24ssx_Chip_Manager_py3v1.py	9.46% <11.68%> (+5.79%)	⬆️
...4/serial/fixed_target/i24ssx_Chip_StartUp_py3v1.py	35.10% <21.42%> (+13.30%)	⬆️
...4/serial/fixed_target/i24ssx_Chip_Collect_py3v1.py	29.96% <28.67%> (+16.77%)	⬆️
...4/serial/extruder/i24ssx_Extruder_Collect_py3v2.py	73.83% <68.81%> (+2.44%)	⬆️
src/mx_bluesky/I24/serial/log.py	96.00% <96.00%> (ø)
src/mx_bluesky/I24/serial/parameters/constants.py	100.00% <100.00%> (ø)
...luesky/I24/serial/setup_beamline/setup_beamline.py	37.11% <100.00%> (+11.80%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[DominicOram]

Great, good to see a bit more tidying, thanks! Minor comments in code, otherwise good

[Tom-Willemsen]

I'm assuming you've run this on the beamline to check the validity of the functional changes? Or is that scheduled for a later time?

[noemifrisina]

I'm assuming you've run this on the beamline to check the validity of the functional changes? Or is that scheduled for a later time?

It's scheduled for later, once the tidying up is completed and we have a way to deploy it (but before adding any bluesky to it). Since it needs a lot of changes, tidying up/ removing things has been split up in multiple PRs to avoid having a massive one.

stale