Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MR-2369: turn on rates db refactor flag for cypress #1957

Merged

Conversation

JasonLin0991
Copy link
Contributor

Summary

MR-2369

  • Turns on rates-db-refactor flag for Cypress tests
  • Turns on supporting-docs-by-rate flag for Cypress tests
    • Since supporting-docs-by-rate is dependent on rates-db-refactor, the UI changes behind it were never activated in dev. By activating rates-db-refactor in dev we now see the UI in dev Cypress tests.
    • All tests have been updated for the UI changes.
  • Skip questionsResponse.spec tests because we have not migrated the Q&A API endpoint yet.
  • NOTE Currently, the change history is incorrect and our cypress tests does not accurately test the change history and its order.
    • This test is in unlockResubmit.spec
    • It still passes
    • I will have a follow-up ticket to address this once we fix the change history. See the rates db refactor notes doc for more info on the investigation of the bug.

Related issues

Screenshots

Test cases covered

QA guidance

Copy link
Contributor

@haworku haworku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once again thanks for clear PR description it helps me a lot as a reviewer.

@JasonLin0991 JasonLin0991 merged commit 0ad0e6c into main Oct 5, 2023
27 checks passed
@JasonLin0991 JasonLin0991 deleted the jl-mr-2369-turn-on-rates-db-refactor-flag-for-cypress branch October 5, 2023 19:27
haworku pushed a commit that referenced this pull request Oct 16, 2023
* Enable `rates-db-refactor` and `supporting-docs-by-rate` flag for cypress tests.

* Skip Q&A tests, resolver not modified for refactor yet.

* cypress re-run

* Update virusScan test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants