Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-GRC Tuning #21

Merged
merged 144 commits into from
Oct 3, 2024
Merged

Pre-GRC Tuning #21

merged 144 commits into from
Oct 3, 2024

Conversation

GreenTomato5
Copy link
Collaborator

Adds CAN IDs taken from last years configs for each module in constants. These should be CHECKED PLEASE because the IDs may be mixed up and likley are. This is because we didn't properly name our modules last year when using YAGSL so "Front left" in configs wasn't actually front left. But the wheels should still move. I also added the NavX IO abstraction which currently uses the MXP port. This may need to be adjusted to use USB C but for now it should be fine.

Copy link
Contributor

@PotmanNob PotmanNob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just double check the CAN ids just in case.

@GreenTomato5 GreenTomato5 linked an issue Aug 10, 2024 that may be closed by this pull request
@GreenTomato5
Copy link
Collaborator Author

Problem is bc talons and sparks are using a different odo thread and the talons use blocking (so they wait for motor controller to report data and that adds latency so the data collected isnt aligned with the timestamps of the spark data collected) and the sparks use polling (just ask the sparks for data). Idk how to effectivley mix the two sampling types so the odo data works and it would probably take a lot of time so I'm gona switch it to the non advanced swerve template so we can get to testing important stuff faster

@GreenTomato5
Copy link
Collaborator Author

I lied, made a mixed thread so should maybe work

@GreenTomato5
Copy link
Collaborator Author

Todo (After sept 9, putting this here so we don't forget):

  • Fix absolute encoder offsets, idk why they weren't offsetting
  • Add back sys id and test it for drive controller values (once we get ground)
  • PID tune (and probably change the setpoints) of intake, amp bar, and shooter states
  • Write climbers
  • Automatic state transitions based on at setpoint, timers, and current sensing
  • Add beam breaks or sumth

@GreenTomato5 GreenTomato5 merged commit 2e83b1e into main Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drive Configs are Wrong
5 participants