-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-GRC Tuning #21
Pre-GRC Tuning #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just double check the CAN ids just in case.
Problem is bc talons and sparks are using a different odo thread and the talons use blocking (so they wait for motor controller to report data and that adds latency so the data collected isnt aligned with the timestamps of the spark data collected) and the sparks use polling (just ask the sparks for data). Idk how to effectivley mix the two sampling types so the odo data works and it would probably take a lot of time so I'm gona switch it to the non advanced swerve template so we can get to testing important stuff faster |
I lied, made a mixed thread so should maybe work |
…Rewrite into Fix-Drive-Configs
Todo (After sept 9, putting this here so we don't forget):
|
18e0ad0
to
a3e5b8b
Compare
3c56e62
to
1010f86
Compare
Adds CAN IDs taken from last years configs for each module in constants. These should be CHECKED PLEASE because the IDs may be mixed up and likley are. This is because we didn't properly name our modules last year when using YAGSL so "Front left" in configs wasn't actually front left. But the wheels should still move. I also added the NavX IO abstraction which currently uses the MXP port. This may need to be adjusted to use USB C but for now it should be fine.