[pull] main from autowarefoundation:main

.cppcheck_suppressions

@@ -1,7 +1,6 @@
 *:*/test/*
 
 checkersReport
-constParameterPointer
 constParameterReference
 constVariable
 constVariableReference
@@ -23,8 +22,6 @@ noValidConfiguration
 passedByValue
 preprocessorErrorDirective
 redundantInitialization
-returnByReference
-shadowArgument
 shadowFunction
 shadowVariable
 syntaxError

.github/CODEOWNERS

@@ -185,12 +185,12 @@ planning/behavior_velocity_planner/autoware_behavior_velocity_occlusion_spot_mod
 planning/behavior_velocity_planner/autoware_behavior_velocity_planner/** kosuke.takeuchi@tier4.jp kyoichi.sugahara@tier4.jp makoto.kurihara@tier4.jp mamoru.sobue@tier4.jp maxime.clement@tier4.jp satoshi.ota@tier4.jp shumpei.wakabayashi@tier4.jp taiki.tanaka@tier4.jp takayuki.murooka@tier4.jp tomohito.ando@tier4.jp tomoya.kimura@tier4.jp
 planning/behavior_velocity_planner/autoware_behavior_velocity_planner_common/** fumiya.watanabe@tier4.jp isamu.takagi@tier4.jp mamoru.sobue@tier4.jp shumpei.wakabayashi@tier4.jp tomoya.kimura@tier4.jp
 planning/behavior_velocity_planner/autoware_behavior_velocity_run_out_module/** kosuke.takeuchi@tier4.jp makoto.kurihara@tier4.jp shumpei.wakabayashi@tier4.jp takayuki.murooka@tier4.jp tomohito.ando@tier4.jp tomoya.kimura@tier4.jp
+planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/** mdogru@leodrive.ai shumpei.wakabayashi@tier4.jp tomoya.kimura@tier4.jp
 planning/behavior_velocity_planner/autoware_behavior_velocity_stop_line_module/** fumiya.watanabe@tier4.jp shumpei.wakabayashi@tier4.jp tomoya.kimura@tier4.jp zhe.shen@tier4.jp
 planning/behavior_velocity_planner/autoware_behavior_velocity_template_module/** daniel.sanchez@tier4.jp
 planning/behavior_velocity_planner/autoware_behavior_velocity_traffic_light_module/** mamoru.sobue@tier4.jp satoshi.ota@tier4.jp shumpei.wakabayashi@tier4.jp tomoya.kimura@tier4.jp
 planning/behavior_velocity_planner/autoware_behavior_velocity_virtual_traffic_light_module/** kosuke.takeuchi@tier4.jp shumpei.wakabayashi@tier4.jp tomoya.kimura@tier4.jp
 planning/behavior_velocity_planner/autoware_behavior_velocity_walkway_module/** satoshi.ota@tier4.jp shumpei.wakabayashi@tier4.jp takayuki.murooka@tier4.jp tomoya.kimura@tier4.jp
-planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/** mdogru@leodrive.ai shumpei.wakabayashi@tier4.jp tomoya.kimura@tier4.jp
 planning/motion_velocity_planner/autoware_motion_velocity_dynamic_obstacle_stop_module/** mamoru.sobue@tier4.jp maxime.clement@tier4.jp
 planning/motion_velocity_planner/autoware_motion_velocity_obstacle_velocity_limiter_module/** maxime.clement@tier4.jp
 planning/motion_velocity_planner/autoware_motion_velocity_out_of_lane_module/** maxime.clement@tier4.jp shumpei.wakabayashi@tier4.jp takayuki.murooka@tier4.jp tomoya.kimura@tier4.jp

.github/pull_request_template.md

@@ -0,0 +1,61 @@
+## Description
+
+## Related links
+
+**Parent Issue:**
+
+- Link
+
+<!-- ⬇️🟢
+**Private Links:**
+
+- [CompanyName internal link]()
+⬆️🟢 -->
+
+## How was this PR tested?
+
+## Notes for reviewers
+
+None.
+
+## Interface changes
+
+None.
+
+<!-- ⬇️🔴
+
+### Topic changes
+
+#### Additions and removals
+
+| Change type   | Topic Type      | Topic Name    | Message Type        | Description       |
+|:--------------|:----------------|:--------------|:--------------------|:------------------|
+| Added/Removed | Pub/Sub/Srv/Cli | `/topic_name` | `std_msgs/String`   | Topic description |
+
+#### Modifications
+
+| Version | Topic Type      | Topic Name        | Message Type        | Description       |
+|:--------|:----------------|:------------------|:--------------------|:------------------|
+| Old     | Pub/Sub/Srv/Cli | `/old_topic_name` | `sensor_msgs/Image` | Topic description |
+| New     | Pub/Sub/Srv/Cli | `/new_topic_name` | `sensor_msgs/Image` | Topic description |
+
+### ROS Parameter Changes
+
+#### Additions and removals
+
+| Change type   | Parameter Name | Type     | Default Value | Description       |
+|:--------------|:---------------|:---------|:--------------|:------------------|
+| Added/Removed | `param_name`   | `double` | `1.0`         | Param description |
+
+#### Modifications
+
+| Version | Parameter Name   | Type     | Default Value | Description       |
+|:--------|:-----------------|:---------|:--------------|:------------------|
+| Old     | `old_param_name` | `double` | `1.0`         | Param description |
+| New     | `new_param_name` | `double` | `1.0`         | Param description |
+
+🔴⬆️ -->
+
+## Effects on system behavior
+
+None.

.github/sync-files.yaml

@@ -7,9 +7,6 @@
     - source: .github/ISSUE_TEMPLATE/bug.yaml
     - source: .github/ISSUE_TEMPLATE/config.yml
     - source: .github/ISSUE_TEMPLATE/task.yaml
-    - source: .github/PULL_REQUEST_TEMPLATE.md
-    - source: .github/PULL_REQUEST_TEMPLATE/small-change.md
-    - source: .github/PULL_REQUEST_TEMPLATE/standard-change.md
     - source: .github/dependabot.yaml
     - source: .github/stale.yml
     - source: .github/workflows/cancel-previous-workflows.yaml

.github/workflows/comment-on-pr.yaml

@@ -0,0 +1,25 @@
+name: comment-on-pr
+on:
+  pull_request_target:
+
+jobs:
+  comment-on-pr:
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+    steps:
+      - name: Check out repository
+        uses: actions/checkout@v4
+
+      - name: Initial PR comment
+        uses: marocchino/sticky-pull-request-comment@v2
+        with:
+          message: |
+            Thank you for contributing to the Autoware project!
+
+            🚧 If your pull request is in progress, [switch it to draft mode](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request#converting-a-pull-request-to-a-draft).
+
+            Please ensure:
+            - You've checked our [contribution guidelines](https://autowarefoundation.github.io/autoware-documentation/main/contributing/).
+            - Your PR follows our [pull request guidelines](https://autowarefoundation.github.io/autoware-documentation/main/contributing/pull-request-guidelines/).
+            - All required CI checks pass before [marking the PR ready for review](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request#marking-a-pull-request-as-ready-for-review).

common/autoware_test_utils/include/autoware_test_utils/autoware_test_utils.hpp

@@ -31,6 +31,7 @@
 #include <geometry_msgs/msg/pose_stamped.hpp>
 #include <nav_msgs/msg/occupancy_grid.hpp>
 #include <nav_msgs/msg/odometry.hpp>
+#include <rosgraph_msgs/msg/clock.hpp>
 #include <sensor_msgs/msg/point_cloud2.hpp>
 #include <std_msgs/msg/bool.hpp>
 #include <tf2_msgs/msg/tf_message.hpp>
@@ -527,6 +528,7 @@ class AutowareTestManager
   AutowareTestManager()
   {
     test_node_ = std::make_shared<rclcpp::Node>("autoware_test_manager_node");
+    pub_clock_ = test_node_->create_publisher<rosgraph_msgs::msg::Clock>("/clock", 1);
   }
 
   template <typename MessageType>
@@ -560,10 +562,28 @@ class AutowareTestManager
     }
   }
 
+  /**
+   * @brief Publishes a ROS Clock message with the specified time.
+   *
+   * This function publishes a ROS Clock message with the specified time.
+   * Be careful when using this function, as it can affect the behavior of
+   * the system under test. Consider using ament_add_ros_isolated_gtest to
+   * isolate the system under test from the ROS clock.
+   *
+   * @param time The time to publish.
+   */
+  void jump_clock(const rclcpp::Time & time)
+  {
+    rosgraph_msgs::msg::Clock clock;
+    clock.clock = time;
+    pub_clock_->publish(clock);
+  }
+
 protected:
   // Publisher
   std::unordered_map<std::string, std::shared_ptr<rclcpp::PublisherBase>> publishers_;
   std::unordered_map<std::string, std::shared_ptr<rclcpp::SubscriptionBase>> subscribers_;
+  rclcpp::Publisher<rosgraph_msgs::msg::Clock>::SharedPtr pub_clock_;
 
   // Node
   rclcpp::Node::SharedPtr test_node_;

common/tier4_camera_view_rviz_plugin/src/bird_eye_view_controller.cpp

@@ -53,7 +53,7 @@
 #include <OgreQuaternion.h>
 #include <OgreSceneManager.h>
 #include <OgreSceneNode.h>
-#include <OgreVector3.h>
+#include <OgreVector.h>
 #include <OgreViewport.h>
 
 namespace tier4_camera_view_rviz_plugin

common/tier4_camera_view_rviz_plugin/src/bird_eye_view_controller.hpp

@@ -46,7 +46,7 @@
 #include "rviz_common/frame_position_tracking_view_controller.hpp"
 
 #include <OgreQuaternion.h>
-#include <OgreVector3.h>
+#include <OgreVector.h>
 
 namespace rviz_common
 {

common/tier4_camera_view_rviz_plugin/src/third_person_view_controller.cpp

@@ -56,7 +56,7 @@
 #include <OgreQuaternion.h>
 #include <OgreRay.h>
 #include <OgreSceneNode.h>
-#include <OgreVector3.h>
+#include <OgreVector.h>
 #include <OgreViewport.h>
 #include <stdint.h>
 

common/tier4_camera_view_rviz_plugin/src/third_person_view_controller.hpp

@@ -45,7 +45,7 @@
 
 #include "rviz_default_plugins/view_controllers/orbit/orbit_view_controller.hpp"
 
-#include <OgreVector3.h>
+#include <OgreVector.h>
 
 #include <utility>
 

common/tier4_perception_rviz_plugin/src/tools/util.hpp

@@ -17,7 +17,7 @@
 
 #include <rviz_common/viewport_mouse_event.hpp>
 
-#include <OgreVector3.h>
+#include <OgreVector.h>
 
 #include <optional>
 

common/tier4_vehicle_rviz_plugin/src/tools/velocity_history.hpp

@@ -26,7 +26,7 @@
 
 #include <OgreColourValue.h>
 #include <OgreManualObject.h>
-#include <OgreVector3.h>
+#include <OgreVector.h>
 
 #include <deque>
 #include <memory>

control/autoware_smart_mpc_trajectory_follower/autoware_smart_mpc_trajectory_follower/scripts/drive_functions.py

@@ -297,7 +297,7 @@
 for curDir, dirs, files in os.walk(control_dir_path):
     for name in files:
         if name == "vehicle_cmd_gate.param.yaml":
-            if curDir.split("/")[-2] == "vehicle_cmd_gate":
+            if curDir.split("/")[-2] == "autoware_vehicle_cmd_gate":
                 limit_yaml_path = curDir + "/" + name
                 break