lomiri.lomiri-ui-extras: init at 0.6.2 #247101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
This comment was marked as resolved.
This comment was marked as resolved.
OPNA2608
force-pushed
the
init/lomiri/lomiri-ui-extras
branch
from
1766e09
to
25ae0a1
Compare
13 tasks
OPNA2608
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
OPNA2608
force-pushed
the
init/lomiri/lomiri-ui-extras
branch
from
39c82a3
to
c4a9fad
Compare
OPNA2608
force-pushed
the
init/lomiri/lomiri-ui-extras
branch
from
c4a9fad
to
2ec6f4c
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3107 |
SuperSandro2000
approved these changes
Dec 16, 2023
SuperSandro2000
approved these changes
Dec 16, 2023
OPNA2608
force-pushed
the
init/lomiri/lomiri-ui-extras
branch
from
c5e4f49
to
50de886
Compare
Squashed.
I don't have merge permissions. |
SuperSandro2000
approved these changes
Dec 18, 2023
pbsds
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Result of nixpkgs-review pr 247101 run on x86_64-linux 1
1 package built:
- lomiri.lomiri-ui-extras
- package path fits guidelines
- package name fits guidelines
- package version fits guidelines
- package builds on x86_64-linux
- executables tested on x86_64-linux
- just a lib, but
env -i lddis happy
- just a lib, but
-
meta.descriptionis set and fits guidelines -
meta.licensefits upstream license -
meta.platformsis set -
meta.maintainersis set - build time only dependencies are declared in
nativeBuildInputs - source is fetched using the appropriate function
- the list of
phasesis not overridden - when a phase (like
installPhase) is overridden it starts withrunHook preInstalland ends withrunHook postInstall. - patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed
- patches that are remotely available are fetched rather than vendored
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Working towards #99090.
Lomiri UI Extras, more QML components for Lomiri applications. Required by some Lomiri core applications - gallery, file manager, terminal, web browser.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)