Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fork-cleaner: init at 2.3.1 #303817

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Conversation

isabelroses
Copy link
Member

@isabelroses isabelroses commented Apr 13, 2024

Description of changes

Adds caarlos0/fork-cleaner, a tool to quickly clean up unused forks on your github account.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@isabelroses
Copy link
Member Author

isabelroses commented Apr 14, 2024

Result of nixpkgs-review pr 303817 run on x86_64-linux 1

1 package built:
  • fork-cleaner

@isabelroses isabelroses mentioned this pull request Apr 14, 2024
13 tasks
@isabelroses isabelroses force-pushed the add-fork-cleaner branch 2 times, most recently from 7ad8ff9 to 8448fc6 Compare April 14, 2024 15:08
@uncenter
Copy link
Member

Seems to be outputting the wrong version?

image

Normally I get this.

image

@isabelroses
Copy link
Member Author

isabelroses commented Apr 14, 2024

Seems to be outputting the wrong version?

Resolved.

Copy link
Member

@tomodachi94 tomodachi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just some tangential things.

pkgs/by-name/fo/fork-cleaner/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fo/fork-cleaner/package.nix Outdated Show resolved Hide resolved
Copy link
Member

@tomodachi94 tomodachi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for this PR (might use this myself).

Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format looks a bit weird, is it alejandra or something?

pkgs/by-name/fo/fork-cleaner/package.nix Outdated Show resolved Hide resolved
@isabelroses
Copy link
Member Author

The format looks a bit weird, is it alejandra or something?

Good catch ill reformat soon.

@Aleksanaa Aleksanaa merged commit 5302e89 into NixOS:master Apr 20, 2024
24 checks passed
@isabelroses isabelroses deleted the add-fork-cleaner branch April 20, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants