Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pace: init at 0.15.2 #303997

Merged
merged 2 commits into from
Apr 14, 2024
Merged

pace: init at 0.15.2 #303997

merged 2 commits into from
Apr 14, 2024

Conversation

isabelroses
Copy link
Member

@isabelroses isabelroses commented Apr 14, 2024

Description of changes

Adds pace-rs/pace, a tool for time-tracking.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Some changes below.

Also, do please rebase such that the maintainer commit is added first on this PR as well

pkgs/by-name/pa/pace/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pa/pace/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pa/pace/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pa/pace/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pa/pace/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pa/pace/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pa/pace/package.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't really put the program through its paces (ha) but it appears to run fine. Will approve after the change below.

pkgs/by-name/pa/pace/package.nix Show resolved Hide resolved
@isabelroses
Copy link
Member Author

Thanks for taking the time to review.

@eclairevoyant eclairevoyant merged commit efe282a into NixOS:master Apr 14, 2024
23 of 25 checks passed
@isabelroses isabelroses deleted the add-pace branch April 14, 2024 15:03
@uncenter uncenter mentioned this pull request Apr 15, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants