Cache questionnaires and standardize github client access #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use GithubClient inside GithubProtocolFetcherStrategy to improve readability and remove deplication. - Use GithubService as a proxy for GithubClient in endpoint. This caches any values from the questionnaire. - Created FunctionCache that caches the result of a throwing function for a given amount of time. - Added more checks on the request being performed: number of bytes for content length, more strict URL validation (only https://api.github.com is allowed now instead of for example http://api.github.com.my.domain.
mpgxvii
approved these changes
Jun 15, 2023
| // Failed to get the Uri Map. try using the cached value | ||
| uriMap = projectProtocolUriMap.getCache(); | ||
| } | ||
| return uriMap != null ? uriMap.keySet() : null; |
There was a problem hiding this comment.
Should we return an empty set here instead of returning null?
There was a problem hiding this comment.
I'm not sure -- I've kept the flow as it already existed. If this returns null the calling function returns an empty map, if this returns an empty set the calling function will create a map of ProtocolId to null. I haven't dived into why this behaviour is there, I've just kept it the same.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://api.github.com/is allowed now instead of for examplehttp://api.github.com.my.domain:9001/.