Tests for task requests #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use variables for colors Use constants for messages Extract constants into a separate file
Use console.error in catch statement Avoid unexpected error due to undefined value
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| async function approveTaskRequest(userId) { | ||
| try { | ||
| console.error(taskRequestId, userId); |
Check failure
Code scanning / CodeQL
Use of externally-controlled format string High
TanishqSingla
force-pushed
the
test/task-request-tests
branch
from
50e05c8
to
3611358
Compare
Deploying with
|
| Latest commit: |
25d66d7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8e05d9d5.dashboard-rds.pages.dev |
| Branch Preview URL: | https://feature-task-request-ui.dashboard-rds.pages.dev |
TanishqSingla
force-pushed
the
test/task-request-tests
branch
from
3611358
to
1cc8238
Compare
TanishqSingla
force-pushed
the
test/task-request-tests
branch
from
a791e7a
to
3ae2c4f
Compare
ankushdharkar
requested review from
Achintya-Chatterjee,
Pratiyushkumar and
prakashchoudhary07
and removed request for
Achintya-Chatterjee
Closed
prakashchoudhary07
requested changes
Aug 5, 2023
| describe('When the user is super user', () => { | ||
| it('should display the task requests card', async () => { | ||
| const url = await page.evaluate(() => API_BASE_URL); | ||
| console.log(url); |
There was a problem hiding this comment.
Please remove console.log
Comment on lines
+49
to
+54
| const title = await taskCards[0].evaluate( | ||
| (el) => el.children[0].textContent, | ||
| ); | ||
| const purpose = await taskCards[0].evaluate( | ||
| (el) => el.children[1].textContent, | ||
| ); |
There was a problem hiding this comment.
NIT: By accessing children in this way, later if the HTML structure changes then the test will fail
There was a problem hiding this comment.
can I rewrite the code @prakashchoudhary07
Comment on lines
+44
to
+45
| describe('When the user is super user', () => { | ||
| it('should display the task requests card', async () => { |
There was a problem hiding this comment.
there should have been a test, to check if user is not super user
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.