[IBCDPE-1111] upgrade airflow #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2024
thomasyu888
reviewed
Oct 28, 2024
| 1. Update the dockerfile within the orca-recipes repo | ||
| 2. Build the new image `docker build .` | ||
| 3. Tag the build image with the tag you want to use `docker tag sha256:... ghcr.io/sage-bionetworks-workflows/orca-recipes:0.0.1` |
There was a problem hiding this comment.
Ideally in the long term - a github action is set up to do this
There was a problem hiding this comment.
Agreed! It's not much work to do this manually, but a GH action in the orca-recipes repo will make the experience better. I created this ticket to add this logic: https://sagebionetworks.jira.com/browse/IBCDPE-1134
thomasyu888
reviewed
Oct 28, 2024
| @@ -1750,7 +2081,7 @@ pgbouncer: | |||
| command: ["pgbouncer", "-u", "nobody", "/etc/pgbouncer/pgbouncer.ini"] | |||
| # Args to use for PgBouncer(templated). | |||
| args: ~ | |||
| auth_type: md5 | |||
| auth_type: scram-sha-256 | |||
There was a problem hiding this comment.
What is the significance of this change? Or is it the change in defaults
There was a problem hiding this comment.
We are not using their version of pgbouncer so we are not affected. This was the default in the new chart version
thomasyu888
approved these changes
Oct 28, 2024
BWMac
approved these changes
Oct 31, 2024
BryanFauble
added a commit
that referenced
this pull request
Nov 5, 2024
* Upgrade airflow to latest helm chart and airflow:2.9.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
Testing:
Related PRs: