Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IBCDPE-1111] upgrade airflow #42

Merged
merged 9 commits into from
Oct 31, 2024
Merged

[IBCDPE-1111] upgrade airflow #42

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e618b70
Update tag
BryanFauble Oct 28, 2024
8c6cc6a
Point to updated helm chart
BryanFauble Oct 28, 2024
1b72e8c
Update tag
BryanFauble Oct 28, 2024
d5bfd2d
Leave off `statsd`
BryanFauble Oct 28, 2024
8c8c39e
Point to updated airflow tag
BryanFauble Oct 28, 2024
1d99c45
Remove todo comment
BryanFauble Oct 28, 2024
7d00789
Add notes about building a new image
BryanFauble Oct 28, 2024
4a8e4ab
Point to updated orca-recipes airflow image
BryanFauble Oct 31, 2024
e438a5c
Ensure same zone for deployed nodes
BryanFauble Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion modules/apache-airflow/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,20 @@ YAML
## Accessing the web UI
An `admin` user is created for airflow via the `airflow-admin-user-secret` secret that
is added to the namespace. Decode the base64 encoded password/username and use it for
the UI.
the UI.

## Building a new image for airflow
The deployment of our airflow instance depends on a custom apache airflow image being
created and pushed to a public available GCHR url. The image is created from the
`orca-recipes` git repo: <https://github.com/Sage-Bionetworks-Workflows/orca-recipes/tree/main>

1. Update the dockerfile within the orca-recipes repo
2. Build the new image `docker build .`
3. Tag the build image with the tag you want to use `docker tag sha256:... ghcr.io/sage-bionetworks-workflows/orca-recipes:0.0.1`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally in the long term - a github action is set up to do this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! It's not much work to do this manually, but a GH action in the orca-recipes repo will make the experience better. I created this ticket to add this logic: https://sagebionetworks.jira.com/browse/IBCDPE-1134

4. Push to GCHR `docker push ghcr.io/sage-bionetworks-workflows/orca-recipes:0.0.1` (May require an admin of the repo to push this)
5. Update the `values.yaml` file in this `modules/apache-airflow/templates` directory.

Transitive dependencies may also need to be updated when building a new image for
airflow, for example `py-orca` was updated in this example PR: <https://github.com/Sage-Bionetworks-Workflows/py-orca/pull/45>.
Additionally, this PR covers what was completed in order to update the
requirements/dockerfile: <https://github.com/Sage-Bionetworks-Workflows/orca-recipes/pull/71>.
2 changes: 1 addition & 1 deletion modules/apache-airflow/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ spec:
sources:
- repoURL: 'https://airflow.apache.org'
chart: airflow
targetRevision: 1.11.0
targetRevision: 1.15.0
helm:
releaseName: airflow
valueFiles:
Expand Down
Loading