Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for Web Components #1444

Merged
merged 3 commits into from
Oct 25, 2024

Review comments

f6be4f2
Select commit
Loading
Failed to load commit list.
Merged

Improvements for Web Components #1444

Review comments
f6be4f2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 20, 2024 in 0s

50.03% (+0.61%) compared to 0f7d6f7

View this Pull Request on Codecov

50.03% (+0.61%) compared to 0f7d6f7

Details

Codecov Report

Attention: Patch coverage is 75.70093% with 26 lines in your changes missing coverage. Please review.

Project coverage is 50.03%. Comparing base (0f7d6f7) to head (f6be4f2).

Files with missing lines Patch % Lines
...age/WASingleElementCache.class/instance/remove..st 0.00% 5 Missing ⚠️
...nContinuation.class/instance/basicPerformAction.st 0.00% 4 Missing ⚠️
...onentActionContinuation.class/instance/continue.st 0.00% 4 Missing ⚠️
...nSession.class/instance/createContinuationCache.st 0.00% 3 Missing ⚠️
...ActionContinuation.class/instance/jumpToAnchor..st 0.00% 3 Missing ⚠️
...tActionContinuation.class/instance/restoreState.st 0.00% 3 Missing ⚠️
...ctionContinuation.class/instance/shouldRedirect.st 0.00% 3 Missing ⚠️
...tsLibrary.class/instance/seasideWebComponentsJs.st 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1444      +/-   ##
==========================================
+ Coverage   49.42%   50.03%   +0.61%     
==========================================
  Files        9073     8946     -127     
  Lines       80086    79229     -857     
==========================================
+ Hits        39582    39645      +63     
+ Misses      40504    39584     -920

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov