Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for Web Components #1444

Merged
merged 3 commits into from
Oct 25, 2024

Review comments

f6be4f2
Select commit
Loading
Failed to load commit list.
Merged

Improvements for Web Components #1444

Review comments
f6be4f2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Oct 20, 2024 in 0s

75.70% of diff hit (target 49.42%)

View this Pull Request on Codecov

75.70% of diff hit (target 49.42%)

Annotations

Check warning on line 3 in repository/Seaside-WebComponents-Core.package/WASingleContinuationSession.class/instance/createContinuationCache.st

See this annotation in the file changed.

@codecov codecov / codecov/patch

repository/Seaside-WebComponents-Core.package/WASingleContinuationSession.class/instance/createContinuationCache.st#L1-L3

Added lines #L1 - L3 were not covered by tests

Check warning on line 5 in repository/Seaside-WebComponents-Core.package/WASingleElementCache.class/instance/remove..st

See this annotation in the file changed.

@codecov codecov / codecov/patch

repository/Seaside-WebComponents-Core.package/WASingleElementCache.class/instance/remove..st#L1-L5

Added lines #L1 - L5 were not covered by tests

Check warning on line 4 in repository/Seaside-WebComponents-Core.package/WAWebComponentActionContinuation.class/instance/basicPerformAction.st

See this annotation in the file changed.

@codecov codecov / codecov/patch

repository/Seaside-WebComponents-Core.package/WAWebComponentActionContinuation.class/instance/basicPerformAction.st#L1-L4

Added lines #L1 - L4 were not covered by tests

Check warning on line 4 in repository/Seaside-WebComponents-Core.package/WAWebComponentActionContinuation.class/instance/continue.st

See this annotation in the file changed.

@codecov codecov / codecov/patch

repository/Seaside-WebComponents-Core.package/WAWebComponentActionContinuation.class/instance/continue.st#L1-L4

Added lines #L1 - L4 were not covered by tests

Check warning on line 3 in repository/Seaside-WebComponents-Core.package/WAWebComponentActionContinuation.class/instance/jumpToAnchor..st

See this annotation in the file changed.

@codecov codecov / codecov/patch

repository/Seaside-WebComponents-Core.package/WAWebComponentActionContinuation.class/instance/jumpToAnchor..st#L1-L3

Added lines #L1 - L3 were not covered by tests

Check warning on line 3 in repository/Seaside-WebComponents-Core.package/WAWebComponentActionContinuation.class/instance/restoreState.st

See this annotation in the file changed.

@codecov codecov / codecov/patch

repository/Seaside-WebComponents-Core.package/WAWebComponentActionContinuation.class/instance/restoreState.st#L1-L3

Added lines #L1 - L3 were not covered by tests

Check warning on line 3 in repository/Seaside-WebComponents-Core.package/WAWebComponentActionContinuation.class/instance/shouldRedirect.st

See this annotation in the file changed.

@codecov codecov / codecov/patch

repository/Seaside-WebComponents-Core.package/WAWebComponentActionContinuation.class/instance/shouldRedirect.st#L1-L3

Added lines #L1 - L3 were not covered by tests

Check warning on line 40 in repository/Seaside-WebComponents-Core.package/WAWebComponentsLibrary.class/instance/seasideWebComponentsJs.st

See this annotation in the file changed.

@codecov codecov / codecov/patch

repository/Seaside-WebComponents-Core.package/WAWebComponentsLibrary.class/instance/seasideWebComponentsJs.st#L40

Added line #L40 was not covered by tests