Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak UI for new SRT #523

Merged
merged 10 commits into from
Sep 28, 2023
Merged

Tweak UI for new SRT #523

merged 10 commits into from
Sep 28, 2023

Conversation

jernestmyers
Copy link
Contributor

@jernestmyers jernestmyers commented Sep 25, 2023

Addresses the following points from this issue:

  1. Mockup updated after UX meeting Jan 18 2023 https://docs.google.com/presentation/d/1m43IHO6BnkXHpusYR2cnJgWdgazm8jCy1euqBiNyKRA/edit#slide=id.p
  2. Add a checkbox as in the tabular reporter to select one transcript per gene to all report forms where this is now supported. See
    SRT reporter: add flag to download only one transcript per gene (the longest in the result) ApiCommonWebsite#117

Below is a screenshot of the UI changes modeled off of this mockup.

Note that there's a comment in the code that wonders if the flattening of the defline options, which requires adding gene_id to the deflineFields array, would cause trouble with the backend. It does not appear to break anything. I tested my branch with a local dev server pointed at @ryanrdoherty's dev site and the same reports succeed and fail when using this branch versus main.

image

@jernestmyers jernestmyers marked this pull request as ready for review September 25, 2023 21:09
Copy link
Member

@dmfalke dmfalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@jernestmyers jernestmyers merged commit b63ad9c into main Sep 28, 2023
1 check passed
@jernestmyers jernestmyers deleted the srt-ui-tweaks branch September 28, 2023 15:37
@aurreco-uga
Copy link
Member

@jernestmyers could you remove the 1 transcript option in record types other than genes?
Screen Shot 2023-11-15 at 9 04 29 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants