-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak UI for new SRT #523
Merged
Merged
Tweak UI for new SRT #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jernestmyers
force-pushed
the
srt-ui-tweaks
branch
from
September 25, 2023 20:04
9bfd305
to
cd4c3e9
Compare
dmfalke
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
@jernestmyers could you remove the 1 transcript option in record types other than genes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the following points from this issue:
Below is a screenshot of the UI changes modeled off of this mockup.
Note that there's a comment in the code that wonders if the flattening of the defline options, which requires adding
gene_id
to thedeflineFields
array, would cause trouble with the backend. It does not appear to break anything. I tested my branch with a local dev server pointed at @ryanrdoherty's dev site and the same reports succeed and fail when using this branch versusmain
.