Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: patch v7.4.1 with docker image metadata #191

Merged
merged 6 commits into from
May 25, 2024

Conversation

eeberhard
Copy link
Member

Description

In #188, metadata was added to the control libraries docker image to support the new aica-technology/package-builder:v1. This came in as part of the v8 release with other breaking changes. However, some downstream users (aica-technology/modulo) are not yet ready to upgrade to v8 but would still benefit from the docker image metadata. In particular, aica-technology/modulo#92 is blocked.

I would like to retroactively make a patch release v7.4.1 which simply adds the docker image metadata on top of the existing v7.4.0 tag. I would merge this onto the patch/v7.4.1 branch, which currently targets the existing v7.4.0 release tag, and then make a new tag on that updated branch to trigger the CI to build the corresponding image.

Review guidelines

Estimated Time of Review: 2 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@domire8
Copy link
Member

domire8 commented May 19, 2024

How is that going to work with all our CIs? What will happen to the patch/v7.4.1 branch afterwards?

@LouisBrunner
Copy link

How is that going to work with all our CIs? What will happen to the patch/v7.4.1 branch afterwards?

We could add a workflow so that patch/vX.Y.Z are automatically published like a main release. But it's pretty common to have alternative main branches to do backports for older versions.

@eeberhard
Copy link
Member Author

How is that going to work with all our CIs? What will happen to the patch/v7.4.1 branch afterwards?

I was planning to tag the commit on the branch as v7.4.1 after merging and then delete the branch. It's safe to delete the branch, because the tag will still persist the specific commit. And, this PR keeps the history of the changes from base to destination.

I thought about amending the workflow but since we build on tags anyway it's pretty simple that way.

@domire8
Copy link
Member

domire8 commented May 21, 2024

I was planning to tag the commit on the branch as v7.4.1 after merging and then delete the branch.

The CI now detects changes of the VERSION file on push to main, there is no workflow on tag anymore.

@eeberhard
Copy link
Member Author

The CI now detects changes of the VERSION file on push to main, there is no workflow on tag anymore.

oops, of course I was looking at the old CI from v7.4.0. Then I guess we could change the CI in this PR to do what we want on push to patch/v7.4.1

Copy link
Member

@domire8 domire8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this seems okay, might just be worth checking if the v7.4.1 is a correct argument to the two actions

@eeberhard eeberhard merged commit 9cea932 into patch/v7.4.1 May 25, 2024
7 checks passed
@eeberhard eeberhard deleted the patch/v7.4.1-metadata branch May 25, 2024 19:37
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants