Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: version 9.0.0 #192

Merged
merged 4 commits into from
Jun 11, 2024
Merged

release: version 9.0.0 #192

merged 4 commits into from
Jun 11, 2024

Conversation

domire8
Copy link
Member

@domire8 domire8 commented Jun 10, 2024

Description

By changing the base version of ubuntu to 24.04 we're breaking the generated image due to the different version of python. Also, the 24.04 image comes with a user so we dont need to create one (see Dockerfile).

Review guidelines

Estimated Time of Review: 3 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

LouisBrunner
LouisBrunner previously approved these changes Jun 10, 2024
@domire8
Copy link
Member Author

domire8 commented Jun 10, 2024

Modulo builds fine and the tests succeed with this version.

eeberhard
eeberhard previously approved these changes Jun 11, 2024
Copy link
Member

@eeberhard eeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚂

.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
Co-authored-by: Enrico Eberhard <32450951+eeberhard@users.noreply.github.com>
@domire8 domire8 merged commit 1f4c470 into main Jun 11, 2024
5 checks passed
@domire8 domire8 deleted the release/v9 branch June 11, 2024 12:57
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants